Stale Route Parent condition present in Route object

[chauhanshubham]

Description:
When the parent reference in a Route object (on both HTTPRoute and TLSRoute), is updated
to point to a non-existing gateway, the Route parent condition is not updated properly

Repro steps:

1. apply examples/kubernetes/quickstart.yaml - ensure that Gateway has proper Status conditions, with 1 listener condition
   showing attachedRoutes: 1. Ensure that the HTTPRoute also has proper Parent Condition present. The httproute parent condition might look something like this

status:
    parents:
    - conditions:
      - lastTransitionTime: "2022-12-03T07:23:33Z"
        message: Route is accepted
        observedGeneration: 1
        reason: Accepted
        status: "True"
        type: Accepted
      controllerName: gateway.envoyproxy.io/gatewayclass-controller
      parentRef:
        group: gateway.networking.k8s.io
        kind: Gateway
        name: eg

2. Now edit the HTTPRoute to point to a non-existing Gateway i.e.

parentRefs:
    - group: gateway.networking.k8s.io
      kind: Gateway
      name: eg1

Observation
While the Gateway status properly specifies the attachedRoutes: 0, the HTTPRoute on the other hand shows - what appears to be a stale parent condition. i.e.

status:
    parents:
    - conditions:
      - lastTransitionTime: "2022-12-03T07:23:33Z"
        message: Route is accepted
        observedGeneration: 1
        reason: Accepted
        status: "True"
        type: Accepted
      controllerName: gateway.envoyproxy.io/gatewayclass-controller
      parentRef:
        group: gateway.networking.k8s.io
        kind: Gateway
        name: eg

Which is the same as seen earlier.
Note that the HTTPRoute now has no mention of Gateway eg as we changed the reference to eg1, but still the Condition shows a condition that was filled earlier, while it was connected to Gateway eg.

[arkodg]

thanks for raising this issue -

• today, we only process HTTPRoutes associated with an accepted Gateway . This is most likely the reason we are not reprocessing this HTTPRoute since it is no longer attached to an accepted Gateway .
  @youngnick from a spec perspective, do we need to re update the status on such a route, or is that something that is good to have ?

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

[arkodg]

we now delete stale statuses from watchable

gateway/internal/gatewayapi/runner/runner.go

Line 205 in db68027

delete(statusesToDelete.HTTPRouteStatusKeys, key)

these will trigger a delete update

gateway/internal/provider/kubernetes/status.go

Line 61 in db68027

if update.Delete {

we should be deleting all the route parents associated with this controllerName