Optimize the connection between Envoy and gateway to ensure the reliability of the connection

[tmsnan]

Description:

Add the upstream_connection_options in the bootstrap configuration to ensure the reliability of the connection

static_resources:
  clusters:
  - connect_timeout: 10s
    upstream_connection_options:
      tcp_keepalive:
        keepalive_time: 300
    load_assignment:
      cluster_name: xds_cluster
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: {{ .XdsServer.Address }}
                port_value: {{ .XdsServer.Port }}

[optional Relevant Links:]

Any extra documentation required to understand the issue.

[arkodg]

+1 apart from upstream keep alive, are there other knobs we should be setting for the xds_cluster ?

[tmsnan]

+1 apart from upstream keep alive, are there other knobs we should be setting for the xds_cluster ?

I think keep alive is enough to ensure that the network connection is available when there is no configuration update for a long time. I don't know about other scene problems so far?

[zirain]

we can reuse configuration from istio?

      - circuit_breakers:
          thresholds:
          - max_connections: 100000
            max_pending_requests: 100000
            max_requests: 100000
          - max_connections: 100000
            max_pending_requests: 100000
            max_requests: 100000
            priority: HIGH
        connect_timeout: 1s
        http2_protocol_options: {}
        load_assignment:
          cluster_name: xds-grpc
          endpoints:
          - lb_endpoints:
            - endpoint:
                address:
                  pipe:
                    path: ./etc/istio/proxy/XDS
        max_requests_per_connection: 1
        name: xds-grpc
        type: STATIC
        upstream_connection_options:
          tcp_keepalive:
            keepalive_time: 300

[arkodg]

sure, probably need to present a better API here

gateway/internal/xds/translator/cluster.go

Line 29 in 75e7ada

func buildXdsCluster(routeName string, tSocket *corev3.TransportSocket, protocol ProtocolType, endpointType EndpointType) *clusterv3.Cluster {

which can be reused for bootstrap case as well as when these fields can be updated by user for their upstream clusters

[shivanshuraj1333]

I'd like to work on this, can I get it assigned to me?
Thanks!

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days.