From f03d1bb03f0ee495b8103f47a8efa6a2b3c29f54 Mon Sep 17 00:00:00 2001
From: Bill Heaton <billh@envoy.com>
Date: Thu, 4 Mar 2021 14:35:59 -0800
Subject: [PATCH] WIP fill in style guide with current Ember standards

---
 engineering/ember.md | 52 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/engineering/ember.md b/engineering/ember.md
index d4beb17..d8f8534 100644
--- a/engineering/ember.md
+++ b/engineering/ember.md
@@ -3,8 +3,12 @@
 ## Table Of Contents
 
 * [General](#general)
+* [Class syntax](#class-syntax)
 * [Computed Properties](#computed-properties)
 * [Components](#components)
+* [Data down Actions Up](#data-down-actions-up)
+* [Glimmer Components](glimmer-components)
+* [Tailwind CSS](tailwind-css)
 * [Templates](#templates)
 * [Tests](#tests)
 
@@ -68,10 +72,25 @@ ember g component my-component --pod
 ```
 ## Components
 
+### Modals
+
+- Standardized classes for modal design
+
+
+### UI:Button
+
+- Always use, as we set `type=button`
+
 ### Do not create components in zapatos
 
 We used to share components by adding it to zapatos, but we're moving away from this practice. Please share components by adding it to `/components`
 
+## Class Syntax
+
+### TODO
+
+For routes, controllers, components
+
 ## Computed Properties
 
 
@@ -116,8 +135,35 @@ fullName: computed('firstName', 'lastName', {
 
 ```
 
+## Glimmer Components
+
+### Component Args
+
+- constructor with setting local props, args with objects, chain in template or getter in JS?
+
+### Tracked properties
+
+- Concerns for mixed use of computed props passed down from existing controllers
+
+### Computed properties
+
+- Using computed properties instead of getter and setter
+
+
+## Tailwind CSS
+
+- Using important when tailwind css is overwritten or adding to scss?
+
+
+
 ## Templates
 
+### Actions
+
+- Triggering single boolean property, use `action` or `mut`?
+
+### Block Syntax
+
 ### {{#each}} - Specifying Keys
 
 To improve rendering speed, the `{{#each}}` helper favors reusing it's inner block. Behind the scenes Ember compares the identity of each object in the array. Where there is a difference that inner inner dom will be torn down and rerendered. By passing a `key` param we inform `{{#each}}` that it should only tear down its inner dom when a specific property has changed. This is important because componments with state will lose their state when torn down and rerenderd. Specifying a key is one way to make sure this doesn't happen on accident. [more info](https://api.emberjs.com/ember/3.20/classes/Ember.Templates.helpers/methods/each?anchor=each)...
@@ -126,6 +172,12 @@ To improve rendering speed, the `{{#each}}` helper favors reusing it's inner blo
 {{#each array key="<someProp>|@index|@identity" |item|}}
 ```
 
+We should always use the key, I can't think of a reason it would hurt us.
+
+## Named Blocks
+
+- 
+
 ### Don't use partials
 
 Use components instead of partials.