Skip to content

Two bugs about input Chinese #19

@snaill

Description

@snaill

Thanks for your great jobs, when I use EGOTextView, I found two bugs:

  1. crash when I input chinese
  2. after I set FontSize, EGOTextView show default fontSize in first character

I try fixed it, hope useful:

  • (void)setMarkedText:(NSString *)markedText selectedRange:(NSRange)selectedRange {

    NSRange selectedNSRange = self.selectedRange;
    NSRange markedTextRange = self.markedRange;

    NSAttributedString *newString = [[NSAttributedString alloc] initWithString:markedText attributes:self.defaultAttributes];

    if (markedTextRange.location != NSNotFound) {
    if (!markedText)
    markedText = @"";

    [_mutableAttributedString replaceCharactersInRange:markedTextRange withAttributedString:newString]; / fixed for bug 2
    markedTextRange.length = markedText.length;
    

    } else if (selectedNSRange.length > 0) {

    [_mutableAttributedString replaceCharactersInRange:selectedNSRange withAttributedString:newString]; // fixed for bug 2
    markedTextRange.location = selectedNSRange.location;
    markedTextRange.length = markedText.length;
    

    } else {

    [_mutableAttributedString insertAttributedString:newString atIndex:selectedNSRange.location];
    markedTextRange.location = selectedNSRange.location;
    markedTextRange.length = markedText.length;
    

    }

    [newString release];
    selectedNSRange = NSMakeRange(selectedRange.location + markedTextRange.location, selectedRange.length);

    self.attributedString = _mutableAttributedString; // fixed for bug1
    self.markedRange = markedTextRange;
    self.selectedRange = selectedNSRange;

}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions