Review Spaghetti code

[GuilhermeAbraham]

Hi @eniteris, wanted to check if you intend on updating this repository and is willing to take contributions.
I see @Myckou has a fork of this project with a few changes to the python script and adding a lua script to export the legends.
Link: https://github.com/Myckou/armap

Are you 2 collaborating?
If we could merge his changes, I could help with a few contributions as well.
I am currently on my vacations, so I was looking for a cool DF repository to contribute a little.

I appreciate the job you did so far, the generated maps look fancy, this is what got me willing to contribute.

[eniteris]

Hey,
I don't (know how to) use Github very much; mostly I use it to make code public, rather than any kind of collaborative tool/version control.
If you'd like, I can try to figure out how to give you admin access so you can manage the project.

The Steam version doesn't seem to include Legends Export yet, and doesn't run very well on my machine, so I'm not sure how useful this tool will be moving forward.

[GuilhermeAbraham]

Hi @eniteris ,

Sure, if you can get me admin permissions I would love to contribute.
Don't worry too much if this will be useful, the maps generated look nice, most important is that this will be fun!

About using github, I use gitlab on a daily bases, so I am not that familiar with github either.
I don't even know a different way to talk to you other than using the "Issues" tab.

If you give me admin permission I can cherry-pick the commits from @Myckou in your repository (I think).
Then I would do a quick linting (format the code) and separate the parts of the code in functions to help make it easier for future changes. That won't take a lot of work but will be good for any improvement later on.

Out of curiosity, you seem to be familiar with opencv but not that much with coding itself, you are using it just for fun or research? Because the maps do look good.

Lastly, let me know if there is any specific improvement/issue you wanted to address on this repository.

[eniteris]

I've added you as a collaborator, I think that's how it works.

I've been programming as a hobby for over a decade, but mostly for personal use, so I never really internalized proper enterprise coding standards. I pick up various skills when I need to, like opencv, though my favorite was implementing octrees when attempting to program a DF-like once.

[Myckou]

Howdy, found this and started to tinker with it for my own tastes. Just coding for my own fun with little to no proper training so not sure how useful my additions may be. Have some more changes I made since the last time I updated that I'll push through to my fork, though most of it is personal taste in the color palette and changes for my own purposes. I'll try and note what I changed but I've been working on it off and on in between work so some might slip my mind.

[GuilhermeAbraham]

@Myckou can you create a pull request to get your changes merged on @eniteris repository?

[Myckou]

Think I got it done, don't really use GitHub that much.

[GuilhermeAbraham]

Thanks @Myckou .
I think there is a small typo on your revision, you mixed tabs and spaces.
I started doing some small changes and fixed this one as well.

Can you check my branch?
https://github.com/eniteris/armap/tree/1-review-spaghetti-code

@eniteris can we maybe add @Myckou as a contributor too? This will make easier for him to contribute with us.

Let me know if you agree with the changes in my branch and if you have any further suggestion.

I need your help to explain to me how the color palettes work, I want to remove the palettes from the code and create either a JSON or YAML file for each palette, this way making it easier for people to add new palettes and/or edit one palette.

I will add parameter parsing to the python script, if you don't pass any parameter it will run like it runs right now and try to generate maps, but you will be able to use the parameters to customize the script execution. I plan to add 1 parameter that will make the script run a "palette edition" mode, but I really need your help to understand how they work.

Thanks in advance! I hope to help make this tool more fun 😄

[GuilhermeAbraham]

Just a preview of the idea I was proposing: