From 3628d68fb5fda960c102f02449cc8ae74632e4df Mon Sep 17 00:00:00 2001 From: Michelle Santarsiero Date: Sun, 4 Apr 2021 16:00:07 -0400 Subject: [PATCH 1/2] Replace rake task with what we tend to actually run to generate --- lib/tasks/addons.rake | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/tasks/addons.rake b/lib/tasks/addons.rake index 42d5033b..22f0dc09 100644 --- a/lib/tasks/addons.rake +++ b/lib/tasks/addons.rake @@ -85,15 +85,15 @@ namespace :addons do ReadmeView.refresh end - desc 'Queue size data calculations for recently updated addons' + desc 'Queue size data calculations for top 1000 addons' task queue_asset_size_calculations: :environment do - latest_version_ids = Addon.active.where('latest_version_date > ?', 18.months.ago).pluck(:latest_addon_version_id) - latest_version_ids.each do |version_id| + addon_version_ids = Addon.top_n(1000).pluck(:latest_addon_version_id) + addon_version_ids.each do |version_id| if !AddonSize.exists?(addon_version_id: version_id) && !PendingSizeCalculation.exists?(addon_version_id: version_id) PendingSizeCalculation.create!(addon_version_id: version_id) end end - puts "Created PendingSizeCalculations for #{latest_version_ids.size} addon versions" + puts "Created PendingSizeCalculations for #{addon_version_ids.size} addon versions" end desc "Notify Dead Man's Snitch of completion" From f16a7d84af8620d7e2417de6c05e409d2b1ac495 Mon Sep 17 00:00:00 2001 From: Michelle Santarsiero Date: Sun, 4 Apr 2021 16:00:21 -0400 Subject: [PATCH 2/2] Skip addon size creation for wip/unreviewed/score < 6 --- app/lib/npm_addon_data_updater.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/lib/npm_addon_data_updater.rb b/app/lib/npm_addon_data_updater.rb index 5f44f39f..f71ba464 100644 --- a/app/lib/npm_addon_data_updater.rb +++ b/app/lib/npm_addon_data_updater.rb @@ -108,7 +108,7 @@ def update_addon_versions released: @metadata['time'][version], ember_cli_version: (data['devDependencies'] ? data['devDependencies']['ember-cli'] : nil) ) - if ENV['ADDON_SIZES_ENABLED'] + if ENV['ADDON_SIZES_ENABLED'] && should_calculate_size? PendingSizeCalculation.create!(addon_version: addon_version) end @addon.addon_versions << addon_version @@ -116,6 +116,10 @@ def update_addon_versions end end + def should_calculate_size? + @addon.scorable? && @addon.score >= 6 + end + def update_latest_addon_version latest_version = @metadata['dist-tags']['latest'] @addon.latest_addon_version = @addon.addon_versions.find_by(version: latest_version)