App freezes when trying to add window source

[hnorkowski]

Issue

When trying to add a window source the app freezes. It works for adding desktops. It crashed directly wenn pressing on Add -> Window. It never gets to a window selection. Happens in VR and in desktop settings.

Version

Happens with both up-to-date Steam version and latest release from gitlab (3.0.1)

System

OS: Windows 11 (23H2)
Glasses: Pimax Crystal Light
SteamVR

Logs

File verbosity level: 0
date       time                                   file:line     v| 
2024-12-07 18:32:36.684                    Logging.cpp:73    INFO| Launching Desktop+ 3.0.1
2024-12-07 18:32:36.715                    Logging.cpp:106   INFO| { Graphics Capture Support
2024-12-07 18:32:36.715                    Logging.cpp:107   INFO| .   Combined Desktop: Yes
2024-12-07 18:32:36.715                    Logging.cpp:108   INFO| .   Disabling Cursor: Yes
2024-12-07 18:32:36.717                    Logging.cpp:109   INFO| .   Disabling Border: Yes
2024-12-07 18:32:36.717                    Logging.cpp:110   INFO| .   Capture Secondary Windows: No
2024-12-07 18:32:36.717                    Logging.cpp:111   INFO| .   Native Update Limiter: No
2024-12-07 18:32:36.717                    Logging.cpp:106   INFO| }
2024-12-07 18:32:36.717                DesktopPlus.cpp:277   INFO| Loaded WinRT library
2024-12-07 18:32:36.717         DPBrowserAPIClient.cpp:220   INFO| Desktop+ Browser is not available
2024-12-07 18:32:36.717              ConfigManager.cpp:393   INFO| Loading config...
2024-12-07 18:32:36.721              ConfigManager.cpp:680   INFO| Loaded config
2024-12-07 18:32:36.725                DesktopPlus.cpp:296   INFO| Launched Desktop+ UI process
2024-12-07 18:32:36.821                    Logging.cpp:85    INFO| SteamVR Runtime Version: 2.8.7
2024-12-07 18:32:36.821                    Logging.cpp:86    INFO| OpenVR API Version: 2.0.10
2024-12-07 18:32:36.821                    Logging.cpp:90    INFO| { HMD Info
2024-12-07 18:32:36.821                    Logging.cpp:93    INFO| .   Model: Pimax Crystal
2024-12-07 18:32:36.821                    Logging.cpp:95    INFO| .   Manufacturer: Pimax
2024-12-07 18:32:36.821                    Logging.cpp:97    INFO| .   Tracking System: aapvr
2024-12-07 18:32:36.821                    Logging.cpp:90    INFO| }
2024-12-07 18:32:36.821              ConfigManager.cpp:393   INFO| Loading config...
2024-12-07 18:32:36.821              ConfigManager.cpp:680   INFO| Loaded config
2024-12-07 18:32:36.838              OutputManager.cpp:658   INFO| Process was not launched by Steam, setting SteamVR application identity
2024-12-07 18:32:36.841              OutputManager.cpp:696   INFO| Pen input simulation is supported
2024-12-07 18:32:36.841              OutputManager.cpp:285   INFO| Initializing Desktop Duplication...
2024-12-07 18:32:36.841              OutputManager.cpp:2704  INFO| { Detected Outputs
2024-12-07 18:32:36.845              OutputManager.cpp:2760  INFO| .   { GPU 1: AMD Radeon RX 7900 XTX (Device ID 29772)
2024-12-07 18:32:36.845              OutputManager.cpp:2787  INFO| .   .   Desktop 1:    0,   0 | 2560x1440 (\\.\DISPLAY1)
2024-12-07 18:32:36.845              OutputManager.cpp:2760  INFO| .   }
2024-12-07 18:32:36.845              OutputManager.cpp:2704  INFO| }
2024-12-07 18:38:04.161                DesktopPlus.cpp:500   INFO| Shutting down...

File verbosity level: 0
date       time                                   file:line     v| 
2024-12-07 18:32:36.734                    Logging.cpp:73    INFO| Launching Desktop+ 3.0.1
2024-12-07 18:32:36.734              DesktopPlusUI.cpp:62    INFO| Desktop+ UI running in VR mode
2024-12-07 18:32:36.761              DesktopPlusUI.cpp:88    INFO| Loaded WinRT library
2024-12-07 18:32:36.762         DPBrowserAPIClient.cpp:220   INFO| Desktop+ Browser is not available
2024-12-07 18:32:36.795              ConfigManager.cpp:393   INFO| Loading config...
2024-12-07 18:32:36.823              ConfigManager.cpp:680   INFO| Loaded config
2024-12-07 18:32:36.928                    Logging.cpp:85    INFO| SteamVR Runtime Version: 2.8.7
2024-12-07 18:32:36.928                    Logging.cpp:86    INFO| OpenVR API Version: 2.0.10
2024-12-07 18:32:36.928                    Logging.cpp:90    INFO| { HMD Info
2024-12-07 18:32:36.928                    Logging.cpp:93    INFO| .   Model: Pimax Crystal
2024-12-07 18:32:36.928                    Logging.cpp:95    INFO| .   Manufacturer: Pimax
2024-12-07 18:32:36.928                    Logging.cpp:97    INFO| .   Tracking System: aapvr
2024-12-07 18:32:36.928                    Logging.cpp:90    INFO| }
2024-12-07 18:32:36.968              DesktopPlusUI.cpp:135   INFO| Loaded Direct3D
2024-12-07 18:32:37.014              DesktopPlusUI.cpp:146   INFO| Loaded Dear ImGui
2024-12-07 18:32:37.021              DesktopPlusUI.cpp:177   INFO| Finished startup

[elvissteinjr]

Does the application crash or freeze? From the UI logs it seems there wasn't a clean shutdown, so I assume it's a crash and not stuck within an endless loop, but you mentioned both.
Existing overlays should stay operable at least when the UI process stops working. Is that not the case?

I don't have much time right now to dig into this, but a few things come to mind that might help narrow this down:

• Any less common application running that might trigger a bug in the window listing code? The window icon reading code would be my first guess as source of trouble. Could you run DesktopPlusUI.exe without any VR and minimal other applications and see if adding window overlays works then?
• I doubt it behaves differently, but if you first create a desktop overlay, then try to change the capture source in the Overlay Properties ("[x] Show Advanced Settings" needs to be ticked), does that work?
• Does the old v2.8.6 release work? Window icon handling is the same there, but the rest of the UI is different.
• And I suppose the most straight forward thing if it's a crash and you have the tools set up: Are you able to compile and run DesktopPlusUI.exe under a debugger? If not that's fine of course.

Sorry for the troubles.