-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
architectureArchitecture and design concernsArchitecture and design concernsmediumMedium priorityMedium priority
Description
Summary
The LLM decision output is parsed via parseKeyValueXml() but there's no schema validation on the parsed result. Malformed or unexpected values pass through silently.
Affected Files
lib/eliza/plugin-cloud-bootstrap/services/cloud-bootstrap-message-service.ts— XML parsing inrunMultiStepCore
Impact
- Unknown action names pass through (not validated against registered actions before execution)
- Parameters may not be valid JSON (caught by try/catch but no structured error)
isFinishparsed as string, not boolean (implicit conversion)- Retry logic handles parse failures but not semantically invalid output
Recommended Fix
Add lightweight validation after parsing:
- Verify
actionis a known registered action name - Verify
parametersis valid JSON and matches expected schema - Validate
isFinishis explicitly "true" or "false" - Log and handle invalid decisions as parse failures (trigger retry)
Effort estimate: Short (<4h)
Source
Identified by GPT Architect agent during comprehensive plan review (2026-02-06).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
architectureArchitecture and design concernsArchitecture and design concernsmediumMedium priorityMedium priority