From 9b3e43c26db8b979c9d968fc0e0cdb0c134a62af Mon Sep 17 00:00:00 2001 From: Rami Yushuvaev Date: Sat, 31 Jan 2026 14:04:13 +0200 Subject: [PATCH 01/15] Logical Properties in CSS --- assets/css/admin.css | 2 +- assets/dev/css/ea11y-scanner-admin.scss | 6 ++--- assets/dev/css/skip-link.scss | 5 +---- modules/deactivation/assets/css/style.css | 22 +++++++++---------- modules/legacy/assets/css/style.css | 12 +++++----- .../legacy/assets/less/_high-contrast.less | 4 ++-- modules/legacy/assets/less/_toolbar.less | 8 +++---- modules/legacy/components/admin.php | 11 ++-------- modules/legacy/components/upgrade.php | 18 +++++++-------- .../assets/src/components/rating-form.js | 2 +- .../assets/src/layouts/user-feedback-form.js | 4 ++-- .../heading-structure/heading-tree-loader.js | 2 +- .../scanner/assets/js/styles/app.styles.js | 16 +++++++------- .../js/styles/heading-structure.styles.js | 16 +++++++------- .../assets/js/styles/manual-fixes.styles.js | 15 ++++++------- .../js/styles/react-colourful.styles.js | 12 +++------- modules/scanner/components/list-column.php | 2 +- modules/settings/assets/css/style.css | 4 ++-- .../analytics/components/pie-tooltip.js | 2 +- .../assets/js/components/bottom-bar/index.js | 2 +- .../capabilities-item/pro-item-infotip.js | 2 +- .../js/components/color-picker/index.js | 2 +- .../js/components/color-picker/style.css | 4 ++-- .../js/components/position-control/index.js | 4 ++-- .../assets/js/components/quota-bar/index.js | 2 +- .../components/quota-bar/quota-bar-group.js | 2 +- .../js/components/sitemap-settings/index.js | 2 +- .../skip-to-content-settings/index.js | 7 +++--- .../js/components/url-mismatch-modal/index.js | 18 +++++++-------- .../assets/js/layouts/icon-design-settings.js | 3 +-- .../assets/js/layouts/menu-settings.js | 2 +- .../assets/js/layouts/position-settings.js | 3 +-- .../assets/js/layouts/statement-link/index.js | 2 +- .../assets/js/layouts/widget-preview/index.js | 5 ++--- modules/settings/assets/js/pages/analytics.js | 5 +---- .../assets/js/pages/assistant/empty-state.js | 14 ++++++------ .../js/pages/assistant/no-results-state.js | 6 ++--- .../js/pages/assistant/results/table.js | 2 +- .../assets/js/pages/assistant/stats/index.js | 2 +- .../stats/issues-by-category/issue-list.js | 2 +- .../stats/issues-by-level/issue-list.js | 2 +- .../js/pages/assistant/stats/stats.styles.js | 4 +--- .../js/pages/assistant/stats/tooltip.js | 2 +- modules/settings/assets/js/pages/menu.js | 3 +-- .../settings/assets/js/pages/pages.styles.js | 8 +++---- .../settings/banners/bf-sale-2025-banner.php | 9 +++++--- .../banners/elementor-birthday-banner.php | 9 +++++--- .../settings/banners/onboarding-banner.php | 11 ++++++---- 48 files changed, 140 insertions(+), 162 deletions(-) diff --git a/assets/css/admin.css b/assets/css/admin.css index 6ffadf82..e3607038 100644 --- a/assets/css/admin.css +++ b/assets/css/admin.css @@ -8,5 +8,5 @@ } .error-elementor { - border-left-color: #93003F; + border-inline-start-color: #93003F; } diff --git a/assets/dev/css/ea11y-scanner-admin.scss b/assets/dev/css/ea11y-scanner-admin.scss index 27004ce9..f4cff14f 100644 --- a/assets/dev/css/ea11y-scanner-admin.scss +++ b/assets/dev/css/ea11y-scanner-admin.scss @@ -134,7 +134,7 @@ &-n::after { right: 50%; bottom: 100%; - margin-bottom: 5px; + margin-block-end: 5px; transform: translateX(50%); } @@ -142,8 +142,8 @@ top: -5px; right: 50%; bottom: auto; - margin-right: -5px; - border-top-color: rgb(0 0 0 / 0.8); + margin-inline-end: -5px; + border-block-start-color: rgb(0 0 0 / 0.8); } &-hidden::before, diff --git a/assets/dev/css/skip-link.scss b/assets/dev/css/skip-link.scss index bedb5e71..80802fb8 100644 --- a/assets/dev/css/skip-link.scss +++ b/assets/dev/css/skip-link.scss @@ -33,10 +33,7 @@ .ea11y-skip-to-content-link:focus + .ea11y-skip-to-content-backdrop { position: fixed; - top: 0; - right: 0; - left: 0; - bottom: 0; + inset: 0; z-index: 9999; background-color: rgb(0 0 0 / 0.5); } diff --git a/modules/deactivation/assets/css/style.css b/modules/deactivation/assets/css/style.css index c5e649ce..863edd46 100644 --- a/modules/deactivation/assets/css/style.css +++ b/modules/deactivation/assets/css/style.css @@ -40,7 +40,7 @@ } .ea11y-deactivation-content h3 { - margin-top: 0; + margin-block-start: 0; color: #23282d; font-size: 18px; font-weight: 600; @@ -48,15 +48,15 @@ .ea11y-deactivation-content p { color: #666; - margin-bottom: 20px; + margin-block-end: 20px; } .ea11y-feedback-options { - margin-bottom: 20px; + margin-block-end: 20px; } .ea11y-feedback-option { - margin-bottom: 15px; + margin-block-end: 15px; } .ea11y-feedback-option > label { @@ -64,23 +64,23 @@ align-items: center; cursor: pointer; color: #23282d; - margin-bottom: 8px; + margin-block-end: 8px; } .ea11y-feedback-option input[type="radio"] { - margin-right: 8px; + margin-inline-end: 8px; } .ea11y-feedback-text-field { - margin-left: 24px; - margin-top: 8px; + margin-inline-start: 24px; + margin-block-start: 8px; } .ea11y-feedback-text-field label { display: block; font-size: 12px; color: #666; - margin-bottom: 4px; + margin-block-end: 4px; } .ea11y-feedback-text-field input, @@ -105,8 +105,8 @@ flex-direction: row-reverse; justify-content: space-between; gap: 10px; - border-top: 1px solid #e1e1e1; - padding-top: 20px; + border-block-start: 1px solid #e1e1e1; + padding-block-start: 20px; } .ea11y-btn { diff --git a/modules/legacy/assets/css/style.css b/modules/legacy/assets/css/style.css index aea13d87..b22ae4b1 100644 --- a/modules/legacy/assets/css/style.css +++ b/modules/legacy/assets/css/style.css @@ -70,7 +70,7 @@ padding: 10px 0; } #pojo-a11y-toolbar .pojo-a11y-toolbar-overlay ul.pojo-a11y-toolbar-items.pojo-a11y-links { - border-top: 1px solid; + border-block-start: 1px solid; } #pojo-a11y-toolbar .pojo-a11y-toolbar-overlay ul.pojo-a11y-toolbar-items li.pojo-a11y-toolbar-item a { display: block; @@ -82,7 +82,7 @@ font-weight: bold; } #pojo-a11y-toolbar .pojo-a11y-toolbar-overlay ul.pojo-a11y-toolbar-items li.pojo-a11y-toolbar-item a svg { - padding-right: 6px; + padding-inline-end: 6px; display: inline-block; width: 1.5em; font-style: normal; @@ -97,8 +97,8 @@ vertical-align: middle; } body.rtl #pojo-a11y-toolbar .pojo-a11y-toolbar-overlay ul.pojo-a11y-toolbar-items li.pojo-a11y-toolbar-item a svg { - padding-left: 6px; - padding-right: 0; + padding-inline-start: 6px; + padding-inline-end: 0; } @media (max-width: 767px) { #pojo-a11y-toolbar .pojo-a11y-toolbar-overlay p.pojo-a11y-toolbar-title { @@ -593,7 +593,7 @@ body.pojo-a11y-high-contrast u span { color: #FFFF80 !important; } body.pojo-a11y-high-contrast dt { - border-top: thin solid grey !important; + border-block-start: thin solid grey !important; } body.pojo-a11y-high-contrast h1, body.pojo-a11y-high-contrast h1 a, @@ -639,7 +639,7 @@ body.pojo-a11y-high-contrast img { } body.pojo-a11y-high-contrast abbr, body.pojo-a11y-high-contrast acronym { - border-bottom: 1px dotted !important; + border-block-end: 1px dotted !important; } body.pojo-a11y-high-contrast :focus { outline: thin dotted !important; diff --git a/modules/legacy/assets/less/_high-contrast.less b/modules/legacy/assets/less/_high-contrast.less index 776992a5..2b4fb9f9 100644 --- a/modules/legacy/assets/less/_high-contrast.less +++ b/modules/legacy/assets/less/_high-contrast.less @@ -73,7 +73,7 @@ h4 i, h5 em, h5 i, h6 em, h6 i, i, i span, u, u span { color: #FFFF80 !important; } dt { - border-top: thin solid grey !important; + border-block-start: thin solid grey !important; } h1, h1 a, h1 a b, h1 abbr, h1 center, h1 span, h2, h2 a, h2 a b, h2 abbr, h2 center, h2 span, h3, h3 a, h3 a b, @@ -88,7 +88,7 @@ img { background-color: #808080 !important; } abbr, acronym { - border-bottom: 1px dotted !important; + border-block-end: 1px dotted !important; } :focus { outline: thin dotted !important; diff --git a/modules/legacy/assets/less/_toolbar.less b/modules/legacy/assets/less/_toolbar.less index f72ec709..3fb4d13c 100644 --- a/modules/legacy/assets/less/_toolbar.less +++ b/modules/legacy/assets/less/_toolbar.less @@ -85,7 +85,7 @@ padding: 10px 0; &.pojo-a11y-links { - border-top: 1px solid; + border-block-start: 1px solid; } li.pojo-a11y-toolbar-item { @@ -101,7 +101,7 @@ } svg { - padding-right: 6px; + padding-inline-end: 6px; display: inline-block; width: 1.5em; font-style: normal; @@ -135,8 +135,8 @@ body.rtl { a { svg { - padding-left: 6px; - padding-right: 0; + padding-inline-start: 6px; + padding-inline-end: 0; } } } diff --git a/modules/legacy/components/admin.php b/modules/legacy/components/admin.php index ffc15fd2..fc969db5 100644 --- a/modules/legacy/components/admin.php +++ b/modules/legacy/components/admin.php @@ -37,12 +37,9 @@ public function admin_notices() { ?>