From 31e5c8d15f881c49f500e2eac6f899ffbdcd370b Mon Sep 17 00:00:00 2001
From: Leonhard Kargl <leo.kargl@proton.me>
Date: Thu, 23 Jan 2025 19:33:21 +0100
Subject: [PATCH 1/2] Allow locking launchers

---
 data/dock.gschema.xml | 6 ++++++
 src/Launcher.vala     | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/data/dock.gschema.xml b/data/dock.gschema.xml
index 6b50086d..72d62e12 100644
--- a/data/dock.gschema.xml
+++ b/data/dock.gschema.xml
@@ -26,6 +26,12 @@
       <summary>An ordered array of app id's to show as launchers</summary>
       <description>An ordered array of app id's to show as launchers</description>
     </key>
+
+    <key type="b" name="lock-launchers">
+      <default>false</default>
+      <summary>Whether to lock launchers to the dock.</summary>
+      <description>Locking launchers prohibits unpinning apps by dragging them off the dock</description>
+    </key>
   </schema>
   <schema path="/io/elementary/dock/keybindings/" id="io.elementary.dock.keybindings">
     <key type="as" name="launch-dock-1">
diff --git a/src/Launcher.vala b/src/Launcher.vala
index c2798948..a92518bd 100644
--- a/src/Launcher.vala
+++ b/src/Launcher.vala
@@ -406,7 +406,7 @@ public class Dock.Launcher : Gtk.Box {
     }
 
     private bool on_drag_cancel (Gdk.Drag drag, Gdk.DragCancelReason reason) {
-        if (app.pinned && reason == NO_TARGET) {
+        if (app.pinned && reason == NO_TARGET && !settings.get_boolean ("lock-launchers")) {
             var popover = new PoofPopover ();
 
             unowned var window = (MainWindow) get_root ();

From 0470dadb3a8136ec61511e38f562e16a64de03a8 Mon Sep 17 00:00:00 2001
From: Leonhard Kargl <leo.kargl@proton.me>
Date: Sun, 9 Feb 2025 17:28:35 +0100
Subject: [PATCH 2/2] Use enum

---
 data/dock.gschema.xml | 13 +++++++++----
 src/Launcher.vala     |  2 +-
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/data/dock.gschema.xml b/data/dock.gschema.xml
index 72d62e12..17d02a53 100644
--- a/data/dock.gschema.xml
+++ b/data/dock.gschema.xml
@@ -8,6 +8,11 @@
     <value nick='always' value='4'/>
   </enum>
 
+  <enum id="DNDBehavior">
+    <value nick='none' value='0'/>
+    <value nick='unpin' value='1'/>
+  </enum>
+
   <schema path="/io/elementary/dock/" id="io.elementary.dock">
     <key enum="HideMode" name="autohide-mode">
       <default>'overlapping-focus-window'</default>
@@ -27,10 +32,10 @@
       <description>An ordered array of app id's to show as launchers</description>
     </key>
 
-    <key type="b" name="lock-launchers">
-      <default>false</default>
-      <summary>Whether to lock launchers to the dock.</summary>
-      <description>Locking launchers prohibits unpinning apps by dragging them off the dock</description>
+    <key enum="DNDBehavior" name="drag-off-dock-behavior">
+      <default>'unpin'</default>
+      <summary>What to do when a launcher is dragged off the dock.</summary>
+      <description>What happens when a launcher is dragged off the dock and released there</description>
     </key>
   </schema>
   <schema path="/io/elementary/dock/keybindings/" id="io.elementary.dock.keybindings">
diff --git a/src/Launcher.vala b/src/Launcher.vala
index a92518bd..161bd376 100644
--- a/src/Launcher.vala
+++ b/src/Launcher.vala
@@ -406,7 +406,7 @@ public class Dock.Launcher : Gtk.Box {
     }
 
     private bool on_drag_cancel (Gdk.Drag drag, Gdk.DragCancelReason reason) {
-        if (app.pinned && reason == NO_TARGET && !settings.get_boolean ("lock-launchers")) {
+        if (app.pinned && reason == NO_TARGET && settings.get_enum ("drag-off-dock-behavior") == 1) {
             var popover = new PoofPopover ();
 
             unowned var window = (MainWindow) get_root ();