Crash when creating a ConstantBuffer with a Struct type

[TIMONz1535]

I'm creating a Compute Shader on a DX12. I made a NewStruct in Structs tab

then I create a ConstantBuffer in the shader - Resources, Buffer, CBV with a Type Struct of my struct.

When I open the Gigi Viewer, it has a 50% chance of crashing.

The program also generates invalid shader code without a struct declaration and incomplete "Struct_" name.

// Unnamed technique, shader NewShader


Texture2D<float4> tex : register(t0);
ConstantBuffer<Struct_> NewBuffer : register(b0);

#line 2

Minimal sample
cbv_crash.zip

[Atrix256]

Thanks a lot!

As things are designed right now, it isn't intended that you can make a constant buffer yourself like this.
The design is that constant buffers are only used for variable values, and are handled for you.
The most immediate fix for this is for me to remove the CBV option from this drop down.

Beyond that, there's probably a conversation to be had about (small) buffer data being able to go into shaders as constant buffers, because this does relate to performance.

If you have any thoughts on that, let me know.

[TIMONz1535]

It wasn't a smart move from my side. Initially, I tried to port the shader as is

struct ParametersStruct
{
	uint32_t faceIndex;
	uint32_t width;
	uint32_t mipIndex;
	uint32_t numMips;
};

cbuffer _ParametersCB : register(b0)
{
	ParametersStruct Parameters;
};

//usage
float mipIndex = (float)Parameters.mipIndex;

I made a constant buffer and found this issue.

Then I checked Gigi's samples and found that the Variables are already inside the constant buffer. So I declared macro and dummy strings like this. $(Variable: strings are needed for Gigi as a fake usage to fill the constant buffer.

#define Parameters _ComputeReflectionMapCB
// /*$(Variable:faceIndex)*/
// /*$(Variable:width)*/
// /*$(Variable:mipIndex)*/
// /*$(Variable:numMips)*/

it produces

struct Struct__ComputeReflectionMapCB
{
    uint faceIndex;
    uint mipIndex;
    uint numMips;
    uint width;
};

ConstantBuffer<Struct__ComputeReflectionMapCB> _ComputeReflectionMapCB : register(b0);

#define Parameters _ComputeReflectionMapCB
// _ComputeReflectionMapCB.faceIndex
// _ComputeReflectionMapCB.width
// _ComputeReflectionMapCB.mipIndex
// _ComputeReflectionMapCB.numMips

//usage
float mipIndex = (float)Parameters.mipIndex;

Perhaps there could be a better way here to not declare a macro and dummy strings.

Regarding the issue, I didn't need to use a real constant buffers.

[Atrix256]

"Regarding the issue, I didn't need to use a real constant buffers."

Ok cool, that's good to know. So there just need to be better gaurd rails to help people not fall off the road it sounds like.

Very inventive attempt at trying to make it work!