Skip to content

Add a flag that changes the exit code of version to 0 even if there are no new files #597

@wkillerud

Description

@wkillerud

At the time of writing the eik version command does a comparison of the files currently up on Eik and the ones that are on the local or CI machine, that are about to be (maybe) published.

  • eik version exits with an error code if there are no new or changed files locally.

    cli/classes/version.js

    Lines 158 to 162 in 37a6139

    if (same) {
    throw new Error(
    `The current version of this package already contains these files, version change is not needed.`,
    );
    }
  • eik publish, however, exits with code 0 if the user tries to publish to a version that already exists.

    cli/utils/error.js

    Lines 27 to 29 in 37a6139

    case errors.ERR_VERSION_EXISTS:
    this.#exitCode = 0;
    break;

The exit code for eik version makes it a bit tricky to write automated release workflows using the CLI. In a lot of our projects we do want to continue the CI workflow to deploy the server-side of things, even if the client-side hasn't changed.

I see the use for some kind of signal that "hey, nothing changed, you don't have to continue", so I don't want to change the default behaviour of eik version.

However, some kind of flag that changes the exit code to 0 would be useful. There are workarounds of course, but some kind of designed solution would be nice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions