Small optimizations

Author: Vardan2009

eiger/Execution/BuiltInTypes/Array.cs

@@ -7,40 +7,42 @@
 
 namespace EigerLang.Execution.BuiltInTypes;
 
+using System.Text;
+
 class Array : Value
 {
-    public Value[] array;
+    public List<Value> array;
 
-    public Array(string fn, int ln, int ps, Value[] array) : base(fn, ln, ps)
+    public Array(string fn, int ln, int ps, List<Value> array) : base(fn, ln, ps)
     {
         this.array = array;
-        this.filename = fn;
-        this.line = ln;
-        this.pos = ps;
     }
 
     public override Value AddedTo(object other)
     {
         if (other is Array arr)
         {
-            return new Array(filename, line, pos, [.. array, .. arr.array]);
+            var newArr = new List<Value>(array.Count + arr.array.Count);
+            newArr.AddRange(array);
+            newArr.AddRange(arr.array);
+            return new Array(filename, line, pos, newArr);
         }
         else
         {
-            return new Array(filename, line, pos, [.. array, (Value)other]);
+            var newArr = new List<Value>(array.Count + 1);
+            newArr.AddRange(array);
+            newArr.Add((Value)other);
+            return new Array(filename, line, pos, newArr);
         }
     }
 
     public override Boolean ComparisonEqeq(object other)
     {
         if (other is Array arr)
         {
-            return new Boolean(filename, line, pos, arr.array.Length == array.Length && arr.array.SequenceEqual(array));
-        }
-        else
-        {
-            return new Boolean(filename, line, pos, false);
+            return new Boolean(filename, line, pos, arr.array.Count == array.Count && arr.array.SequenceEqual(array));
         }
+        return new Boolean(filename, line, pos, false);
     }
 
     public override Boolean ComparisonNeqeq(object other)
@@ -49,53 +51,53 @@ public override Boolean ComparisonNeqeq(object other)
         {
             return new Boolean(filename, line, pos, !arr.array.SequenceEqual(array));
         }
-        else
-        {
-            return new Boolean(filename, line, pos, true);
-        }
+        return new Boolean(filename, line, pos, true);
     }
 
-    public override Value GetIndex(int idx)
+    private void ValidateIndex(int idx)
     {
-        if (idx < 0 || idx >= array.Length)
+        if (idx < 0 || idx >= array.Count)
             throw new EigerError(filename, line, pos, "Index outside of bounds", EigerError.ErrorType.IndexError);
-        return array[idx];
     }
 
-    public override Value GetAttr(ASTNode attr)
+    public override Value GetIndex(int idx)
     {
-        if (attr.value == "type")
-        {
-            return new String(filename, line, pos, "array");
-        }
-        return base.GetAttr(attr);
+        ValidateIndex(idx);
+        return array[idx];
     }
 
     public override void SetIndex(int idx, Value val)
     {
-        if (idx < 0 || idx >= array.Length)
-            throw new EigerError(filename, line, pos, "Index outside of bounds", EigerError.ErrorType.IndexError);
+        ValidateIndex(idx);
         val.modifiers = array[idx].modifiers;
         array[idx] = val;
     }
 
     public override Value GetLength()
     {
-        return new Number(filename, line, pos, array.Length);
+        return new Number(filename, line, pos, array.Count);
+    }
+
+    public override Value GetAttr(ASTNode attr)
+    {
+        if (attr.value == "type")
+        {
+            return new String(filename, line, pos, "array");
+        }
+        return base.GetAttr(attr);
     }
 
     public override string ToString()
     {
-        string strep = "[";
-        for (int i = 0; i < array.Length; i++)
+        var sb = new StringBuilder();
+        sb.Append('[');
+        for (int i = 0; i < array.Count; i++)
         {
-            strep += array[i].ToString();
-            if (i != array.Length - 1)
-            {
-                strep += ", ";
-            }
+            sb.Append(array[i].ToString());
+            if (i != array.Count - 1)
+                sb.Append(", ");
         }
-        strep += "]";
-        return strep;
+        sb.Append(']');
+        return sb.ToString();
     }
-}
+}

eiger/Execution/BuiltInTypes/Boolean.cs

@@ -12,10 +12,6 @@ public class Boolean : Value
 
     public Boolean(string filename, int line, int pos, bool value) : base(filename, line, pos)
     {
-        this.filename = filename;
-        this.value = value;
-        this.line = line;
-        this.pos = pos;
         this.value = value;
     }
 

eiger/Execution/BuiltInTypes/Class.cs

@@ -12,9 +12,6 @@ public Class(string filename, int line, int pos, string name, ASTNode blockNode)
     {
         if (name == "new")
             throw new EigerLang.Errors.EigerError(filename, line, pos, "`new` is an invalid name for a class", Errors.EigerError.ErrorType.RuntimeError);
-        this.filename = filename;
-        this.line = line;
-        this.pos = pos;
         this.name = name;
         this.blockNode = blockNode;
     }

eiger/Execution/BuiltInTypes/Dataclass.cs

@@ -9,9 +9,6 @@ public class Dataclass : Value
 
     public Dataclass(string filename, int line, int pos, string name, SymbolTable symbolTable, ASTNode blockNode) : base(filename, line, pos)
     {
-        this.filename = filename;
-        this.line = line;
-        this.pos = pos;
         this.name = name;
 
         // create local symbol table

eiger/Execution/BuiltInTypes/Instance.cs

@@ -11,9 +11,6 @@ public class Instance : Value
 
     public Instance(string filename, int line, int pos, Class createdFrom, SymbolTable symbolTable) : base(filename, line, pos)
     {
-        this.filename = filename;
-        this.line = line;
-        this.pos = pos;
         this.name = createdFrom.name;
         this.createdFrom = createdFrom;
         this.symbolTable = symbolTable;

eiger/Execution/BuiltInTypes/Nix.cs

@@ -8,9 +8,6 @@ class Nix : Value
 
     public Nix(string filename, int line, int pos) : base(filename, line, pos)
     {
-        this.filename = filename;
-        this.line = line;
-        this.pos = pos;
     }
 
     public override string ToString()

eiger/Execution/BuiltInTypes/Number.cs

@@ -12,9 +12,6 @@ class Number : Value
 
     public Number(string filename, int line, int pos, double value) : base(filename, line, pos)
     {
-        this.filename = filename;
-        this.line = line;
-        this.pos = pos;
         this.value = value;
     }
 

eiger/Execution/BuiltInTypes/String.cs

@@ -14,9 +14,6 @@ class String : Value
     public String(string filename, int line, int pos, string value) : base(filename, line, pos)
     {
         this.value = value;
-        this.filename = filename;
-        this.line = line;
-        this.pos = pos;
     }
 
     public override Value GetIndex(int idx)

eiger/Execution/BuiltInTypes/Value.cs

@@ -5,7 +5,13 @@ namespace EigerLang.Execution.BuiltInTypes;
 
 public class Value(string _filename, int _line, int _pos)
 {
-    public List<string> modifiers = [];
+    private List<string>? _modifiers;
+    public List<string> modifiers
+    {
+        get => _modifiers ??= new List<string>();
+        set => _modifiers = value;
+    }
+
     public string filename = _filename;
     public int line = _line, pos = _pos;
 
@@ -101,7 +107,7 @@ public virtual void SetIndex(int idx, Value val)
 
     public virtual Value GetLength()
     {
-        throw new EigerError(filename, line, pos, "Object has no length", EigerError.ErrorType.RuntimeError);
+        throw new EigerError(filename, line, pos, "Object of type {this.GetType().Name} has no length", EigerError.ErrorType.RuntimeError);
     }
 
     public virtual Value GetAttr(ASTNode attr)
@@ -142,13 +148,10 @@ public static Value ToEigerValue(string filename, int line, int pos, dynamic val
 
     public override bool Equals(object? obj)
     {
-        if (obj is not null)
-            return ComparisonEqeq(obj).value;
-        else
-            return false;
+        if (ReferenceEquals(this, obj)) return true;
+        if (obj is null || obj.GetType() != this.GetType()) return false;
+        return ComparisonEqeq(obj).value;
     }
 
-    public override int GetHashCode() {
-        return base.GetHashCode();
-    }
+    public override int GetHashCode() => HashCode.Combine(filename, line, pos);
 }

eiger/Execution/Interpreter.cs

@@ -524,6 +524,7 @@ static ReturnResult VisitBinOpNode(ASTNode node, SymbolTable symbolTable)
             "/=" => HandleCompoundAssignment(node, rightSide, symbolTable, (left, right) => left.DivedBy(right)),
             _ => throw new EigerError(node.filename, node.line, node.pos, $"{Globals.InvalidOperationStr}: {node.value}", EigerError.ErrorType.InvalidOperationError),
         };
+        
         return new()
         {
             result = retVal