Ballistic Armor Level doesn't actually do anything

[eezstreet]

Looking at the code for armor impacts here:

simulated function bool HandleBallisticImpact(
    Actor Victim,
    vector HitLocation,
    vector HitNormal,
    vector NormalizedBulletDirection,
    Material HitMaterial,
    ESkeletalRegion HitRegion,
    out float Momentum,
    out float KillEnergy,
    out int BulletType,
    vector ExitLocation,
    vector ExitNormal,
    Material ExitMaterial
    )
{
    local float MomentumToPenetrateVictim;
    local float MomentumLostToVictim;
    local vector MomentumVector;
    local bool PenetratesVictim;
    local int Damage;
    local SkeletalRegionInformation SkeletalRegionInformation;
    local ProtectiveEquipment Protection;
    local int ArmorLevel;
    local int BulletLevel;
    local float DamageModifier, ExternalDamageModifier;
    local float LimbInjuryAimErrorPenalty;
    local IHaveSkeletalRegions SkelVictim;
    local Pawn  PawnVictim;
	local PlayerController OwnerPC;

    BulletType = Ammo.GetBulletType();
    ArmorLevel = Protection.GetProtectionType(); // <-- `Protection` is always None here
    BulletLevel = Ammo.GetPenetrationType();

Protection isn't assigned at the point where it is at, leading to this call always failing and therefore likely not having any actual effect.

[beppegoodoldrebel]

Right but protection is actually initialized in line 801

SWATEliteForce/Source/Unreal/Engine/Classes/Equipment/FiredWeapon.uc

Line 801 in 1614879

Protection = ICanUseProtectiveEquipment(Victim).GetSkeletalRegionProtection(HitRegion);

and used in function HandleProtectiveEquipmentBallisticImpact()

SWATEliteForce/Source/Unreal/Engine/Classes/Equipment/FiredWeapon.uc

Line 1064 in 1614879

ArmorLevel = Protection.GetProtectionType();

[eezstreet]

Line 801 comes after that line.

[beppegoodoldrebel]

ArmorLevel is passed None to HandleProtectiveEquipmentBallisticImpact() but initialized again in line 1064 where Protection is not None anymore.

SWATEliteForce/Source/Unreal/Engine/Classes/Equipment/FiredWeapon.uc

Line 1064 in 1614879

ArmorLevel = Protection.GetProtectionType();

if you enable the ballisticlog you'll that everything is working fine.

[eezstreet]

Maybe I am not explaining myself properly, but it isn't. Click the link I posted.

[kevinfoley]

@eezstreet beppe is actually right, ArmorLevel and BulletLevel aren't used in this function, and though they are passed to another function, they are reloaded in that function anyway. Anyway, I've cleaned it up in #727, so this issue can be closed.