Skip to content

refactor: update static storage configuration for Django 5.2+ compatibility #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jignaciopm wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor: update static storage configuration for Django 5.2+ compatibility #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
098e1ac
refactor: update static storage configuration for Django 5.2+ compati…
jignaciopm Jan 18, 2026
8177e22
fix: restore support Teak and lower
jignaciopm Jan 18, 2026
826cdad
fix: another test
jignaciopm Jan 18, 2026
d4172a1
fix: minor
jignaciopm Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
strategy:
fail-fast: false
matrix:
tutor_version: ['<20.0.0', '<21.0.0', 'main']
tutor_version: ['<22.0.0', '<21.0.0', 'main']
steps:
- name: Run Integration Tests
uses: eduNEXT/integration-test-in-tutor@main
uses: eduNEXT/integration-test-in-tutor@v0.1.0
with:
tutor_version: ${{ matrix.tutor_version }}
app_name: 'eox-theming'
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [v9.3.1](https://github.com/eduNEXT/eox-theming/compare/v9.3.0...v9.3.1) - (2026-01-18)

### Changed

- **Django 5.2 Compatibility**: Migrated static files storage configuration from the deprecated `STATICFILES_STORAGE` setting to the new `STORAGES` dictionary.

## [v9.3.0](https://github.com/eduNEXT/eox-theming/compare/v9.2.0...v9.3.0) - (2025-10-13)

### Changed
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,6 @@ quality: clean ## check coding style with pycodestyle and pylint
test-python: clean ## Run test suite.
$(TOX) pip install -r requirements/test.txt --exists-action w
$(TOX) coverage run --source="." -m pytest ./eox_theming --ignore-glob='**/integration/*'
$(TOX) coverage report -m --fail-under=74
$(TOX) coverage report -m --fail-under=73

run-tests: test-python quality
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Compatibility Notes
+------------------+---------------+
| Teak | >= 9.0.0 |
+------------------+---------------+
| Ulmo | >= 9.3.0 |
| Ulmo | >= 9.3.1 |
+------------------+---------------+

The plugin is configured for the latest release (Teak). If you need compatibility for previous releases, go to the README of the relevant version tag and if it is necessary you can change the configuration in ``eox_theming/settings/common.py``.
Expand Down
2 changes: 1 addition & 1 deletion eox_theming/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@

from __future__ import unicode_literals

__version__ = '9.3.0'
__version__ = '9.3.1'
6 changes: 5 additions & 1 deletion eox_theming/settings/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ def plugin_settings(settings):
settings.EOX_THEMING_CONFIGURATION_HELPER_BACKEND = 'eox_theming.edxapp_wrapper.backends.j_configuration_helpers'
settings.EOX_THEMING_THEMING_HELPER_BACKEND = 'eox_theming.edxapp_wrapper.backends.j_theming_helpers'
settings.EOX_THEMING_STORAGE_BACKEND = 'eox_theming.edxapp_wrapper.backends.l_storage'
settings.STATICFILES_STORAGE = 'eox_theming.theming.storage.EoxProductionStorage'

if not hasattr(settings, 'STORAGES'):
settings.STATICFILES_STORAGE = 'eox_theming.theming.storage.EoxProductionStorage'
else:
settings.STORAGES.setdefault('staticfiles', {})['BACKEND'] = 'eox_theming.theming.storage.EoxProductionStorage'

settings.EOX_THEMING_EDXMAKO_BACKEND = 'eox_theming.edxapp_wrapper.backends.l_mako'
5 changes: 4 additions & 1 deletion eox_theming/settings/devstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,7 @@ def plugin_settings(settings):
'eox_theming.theming.finders.EoxThemeFilesFinder',
] + settings.STATICFILES_FINDERS

settings.STATICFILES_STORAGE = 'eox_theming.theming.storage.EoxDevelopmentStorage'
if not hasattr(settings, 'STORAGES'):
settings.STATICFILES_STORAGE = 'eox_theming.theming.storage.EoxProductionStorage'
else:
settings.STORAGES.setdefault('staticfiles', {})['BACKEND'] = 'eox_theming.theming.storage.EoxProductionStorage'
7 changes: 6 additions & 1 deletion eox_theming/settings/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ def plugin_settings(settings): # pylint: disable=function-redefined
except AttributeError:
pass

settings.STATICFILES_STORAGE = 'openedx.core.storage.ProductionStorage'
settings.STATICFILES_STORAGE = 'eox_theming.theming.storage.EoxProductionStorage'

if not hasattr(settings, 'STORAGES'):
settings.STORAGES = {}

settings.STORAGES.setdefault('staticfiles', {})['BACKEND'] = 'eox_theming.theming.storage.EoxProductionStorage'

settings.STATICFILES_FINDERS = [
x for x in settings.STATICFILES_FINDERS if 'EoxThemeFilesFinder' not in x
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 9.3.0
current_version = 9.3.1
commit = False
tag = False

Expand Down
Loading