Merge pull request The-OpenROAD-Project#3929 from eder-matheus/ppl_fix_crash

maliberty · web-flow · commit 1f6ccc9066e7 · 2023-08-30T22:04:27.000-07:00
ppl: check available slots agains number of pins in the correct place
diff --git a/src/ppl/src/IOPlacer.cpp b/src/ppl/src/IOPlacer.cpp
@@ -865,6 +865,15 @@ void IOPlacer::defineSlots()
   findSlots(hor_layers_, Edge::left);
 
   findSlotsForTopLayer();
+
+  if (netlist_io_pins_->getIOPins().size() > slots_.size()) {
+    logger_->error(PPL,
+                   24,
+                   "Number of IO pins ({}) exceeds maximum number of available "
+                   "positions ({}).",
+                   netlist_io_pins_->getIOPins().size(),
+                   slots_.size());
+  }
 }
 
 void IOPlacer::findSections(int begin,
@@ -1290,8 +1299,10 @@ void IOPlacer::printConfig(bool annealing)
   logger_->info(PPL, 1, "Number of slots          {}", slots_.size());
   logger_->info(PPL, 2, "Number of I/O            {}", netlist_->numIOPins());
   logger_->metric("floorplan__design__io", netlist_->numIOPins());
-  logger_->info(
-      PPL, 3, "Number of I/O w/sink     {}", netlist_io_pins_->numIOPins());
+  logger_->info(PPL,
+                3,
+                "Number of I/O w/sink     {}",
+                netlist_io_pins_->numIOPins() - zero_sink_ios_.size());
   logger_->info(PPL, 4, "Number of I/O w/o sink   {}", zero_sink_ios_.size());
   if (!annealing) {
     logger_->info(PPL, 5, "Slots per section        {}", slots_per_section_);
@@ -1905,15 +1916,6 @@ void IOPlacer::run(bool random_mode)
   initIOLists();
   defineSlots();
 
-  if (netlist_io_pins_->getIOPins().size() > slots_.size()) {
-    logger_->error(PPL,
-                   24,
-                   "Number of IO pins ({}) exceeds maximum number of available "
-                   "positions ({}).",
-                   netlist_io_pins_->getIOPins().size(),
-                   slots_.size());
-  }
-
   initMirroredPins();
   initConstraints();
 
diff --git a/src/ppl/test/no_instance_pins.ok b/src/ppl/test/no_instance_pins.ok
@@ -10,7 +10,7 @@ Found 0 macro blocks.
 [INFO PPL-0010] Tentative 0 to set up sections.
 [INFO PPL-0001] Number of slots          2494
 [INFO PPL-0002] Number of I/O            10
-[INFO PPL-0003] Number of I/O w/sink     10
+[INFO PPL-0003] Number of I/O w/sink     0
 [INFO PPL-0004] Number of I/O w/o sink   10
 [INFO PPL-0005] Slots per section        200
 [INFO PPL-0006] Slots increase factor    0.01
