Sync monitor service API

[kittaakos]

Hi there, I noticed the protocol has sync API, but the implementation awaits. Can you please confirm which one is correct? Thank you

theia-cloud/theia/extensions/monitor-theia/src/common/monitor-protocol.ts

Line 15 in 58a376d

isRunningOnTheiaCloud(): boolean;

theia-cloud/theia/extensions/monitor-theia/src/browser/modules/activity-tracker-frontend-module-impl.ts

Line 51 in 58a376d

const onTheiaCloud = await this.backendService.isRunningOnTheiaCloud();

[jfaltermeier]

@sgraband Do you remember?

[sgraband]

I am pretty sure that the await could simply be removed. All the method does is check the ENV. Probably just an oversight.

[kittaakos]

await could simply be removed. All the method does is check the ENV.

However, the client requests this from the backend, which goes through the wire. Thus, the API should be async even though it runs sync code on the backend.

theia-cloud/theia/extensions/monitor-theia/src/node/monitor-service.ts

Lines 14 to 19 in 58a376d

	isRunningOnTheiaCloud(): boolean {
	const appId = process.env.THEIACLOUD_APP_ID;
	const serviceUrl = process.env.THEIACLOUD_SERVICE_URL;
	const sessionName = process.env.THEIACLOUD_SESSION_NAME;
	return appId && serviceUrl && sessionName ? true : false;
	}