-
Notifications
You must be signed in to change notification settings - Fork 16
Description
The force qualifier updates build step is a little brittle, this step:
Line 59 in cdbc520
| - [ ] Update the build qualifiers to ensure that packages are all updated. See this [gerrit](https://git.eclipse.org/r/#/c/161075/) for an example. To do this run `releng/org.eclipse.epp.config/tools/setGitDate` ([link](https://github.com/eclipse-packaging/packages/blob/master/releng/org.eclipse.epp.config/tools/setGitDate)) script. This script will make a local commit you need to push. |
Because if you squash or amend the commit so the commit time is overridden the effect goes away as the commit time, not the author time is used.
This results in the following manual check to potentially fail:
Line 76 in cdbc520
| - [ ] `org.eclipse.epp.package.*` features and bundles have the timestamp of the forced qualifier update or later |
The utility of the force qualifier updates is to make sure that we don't publish content with the same version + qualifier but produced at different times.
Perhaps it would be easier to simply remove these steps and stop using the jgit timestamp plug-in and always use build time for the bundles qualifier. I think that would achieve the goal without the overhead.
PS I think there was also the desire to have the timestamps be "pretty" in the past, i.e. org.eclipse.epp.package.common_4.32.0.20240530-1200 instead of org.eclipse.epp.package.common_4.32.0.20240530-0533/
Note that the RC1 (see #166) shows the inconsistency (the build is still ok) because the commit that set the timestamp has different commit and author times. The setGitData script sets the commit date:
| export GIT_COMMITTER_DATE="${GIT_DATE}" |
But the commit for RC1 was different cdbc520