Performing manual setup tasks doesn't resume after restart

[mmosconi1]

If I manually invoke "Perform Setup Tasks..." with some P2 task and others enabled, it requires a restart if P2 did install sth.

But after restarting, it doesn't continue with pending tasks which were selected previously and which are supposed to be executed on startup (rather than bootstrap).

I think this worked some (longer) time ago ... but not sure.

[merks]

It generally seems to work but I think not always. This implementation is a bit tricky. I'll have a look after my vacation.

[merks]

I had a quite look now...

So I did this to force a task that wants a restart

When the IDE shuts down, it saves this file with reference to the tasks that need to be performed still:

./ws/.metadata/.plugins/org.eclipse.oomph.setup.ui/restarting

<?xml version="1.0" encoding="UTF-8"?>
<base:Annotation
    xmi:version="2.0"
    xmlns:xmi="http://www.omg.org/XMI"
    xmlns:base="http://www.eclipse.org/oomph/base/1.0"
    source="MANUAL">
  <reference
      href="../org.eclipse.oomph.setup/workspace.setup#//@setupTasks.6"/>
  <reference
      href="index:/org.eclipse.setup#//@projectCatalogs[name='org.eclipse']/@projects[name='platform']/@setupTasks.7"/>
  <reference
      href="index:/org.eclipse.setup#//@projectCatalogs[name='org.eclipse']/@setupTasks.6"/>
  <reference
      href="index:/org.eclipse.setup#//@projectCatalogs[name='org.eclipse']/@projects[name='platform']/'import.project.eclipse.platform.prereqs.target'"/>
  <reference
      href="index:/org.eclipse.setup#//@projectCatalogs[name='org.eclipse']/@projects[name='platform']/@projects[name='website']/@setupTasks.3"/>
</base:Annotation>

When I restarted it only did these two tasks though:

This code is quite fragile with respect to resolving the saved references. Probably assigning an ID to each task would work better. You might want to try that.