Invalid thread access when running default Maven build

[basilevs]

Run mvn clean verify in repository root.
The test application fails to start:

% cat /private/tmp/oomph/plugins/org.eclipse.oomph.setup.installer.tests/target/work/data/.metadata/.log

!SESSION 2025-04-20 01:39:24.840 -----------------------------------------------
eclipse.buildId=unknown
java.version=22.0.1
java.vendor=Homebrew
BootLoader constants: OS=macosx, ARCH=aarch64, WS=cocoa, NL=en_GE
Framework arguments:  -application org.eclipse.tycho.surefire.osgibooter.uitest -testproperties /private/tmp/oomph/plugins/org.eclipse.oomph.setup.installer.tests/target/surefire.properties -testApplication org.eclipse.oomph.setup.installer.application -product org.eclipse.oomph.setup.installer.product -nouithread -timeout 60000
Command-line arguments:  -data /private/tmp/oomph/plugins/org.eclipse.oomph.setup.installer.tests/target/work/data -application org.eclipse.tycho.surefire.osgibooter.uitest -testproperties /private/tmp/oomph/plugins/org.eclipse.oomph.setup.installer.tests/target/surefire.properties -testApplication org.eclipse.oomph.setup.installer.application -product org.eclipse.oomph.setup.installer.product -nouithread -timeout 60000


....
org.eclipse.swt.SWTException: Invalid thread access
        at org.eclipse.swt.SWT.error(SWT.java:4945)
        at org.eclipse.swt.SWT.error(SWT.java:4860)
        at org.eclipse.swt.SWT.error(SWT.java:4831)
        at org.eclipse.swt.widgets.Display.error(Display.java:1211)
        at org.eclipse.swt.widgets.Display.createDisplay(Display.java:962)
        at org.eclipse.swt.widgets.Display.create(Display.java:946)
        at org.eclipse.swt.graphics.Device.<init>(Device.java:132)
        at org.eclipse.swt.widgets.Display.<init>(Display.java:800)
        at org.eclipse.swt.widgets.Display.<init>(Display.java:791)
        at org.eclipse.swt.widgets.Display.getDefault(Display.java:1545)
        at org.eclipse.oomph.ui.UIUtil.getDisplay(UIUtil.java:141)
        at org.eclipse.oomph.ui.UIUtil.syncExec(UIUtil.java:631)
        at org.eclipse.oomph.setup.internal.installer.SetupInstallerPlugin$Implementation.start(SetupInstallerPlugin.java:144)
        at org.eclipse.osgi.internal.framework.BundleContextImpl$2.run(BundleContextImpl.java:826)
        at org.eclipse.osgi.internal.framework.BundleContextImpl$2.run(BundleContextImpl.java:1)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:571)
        at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:818)
        at org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:768)
        at org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:1066)
        at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.startWorker(EquinoxBundle.java:394)
        at org.eclipse.osgi.container.Module.doStart(Module.java:643)
        at org.eclipse.osgi.container.Module.start(Module.java:500)
        at org.eclipse.osgi.framework.util.SecureAction.start(SecureAction.java:528)
        at org.eclipse.osgi.internal.hooks.EclipseLazyStarter.postFindLocalClass(EclipseLazyStarter.java:122)
        at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:622)
        at org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:353)
        at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:417)
        at org.eclipse.osgi.internal.loader.BundleLoader.findClass0(BundleLoader.java:525)
        at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:438)
        at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:195)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
        at org.eclipse.osgi.internal.framework.EquinoxBundle.loadClass(EquinoxBundle.java:652)
        at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:226)
        at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:1034)
        at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:286)
        at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:65)
        at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.getApplicationToRun(AbstractUITestApplication.java:104)
        at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:124)
        at org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:44)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:631)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1435)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1407)

% mvn -version    
Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: /opt/homebrew/Cellar/maven/3.9.8/libexec
Java version: 22.0.1, vendor: Homebrew, runtime: /opt/homebrew/Cellar/openjdk/22.0.1/libexec/openjdk.jdk/Contents/Home
Default locale: en_GE, platform encoding: UTF-8
OS name: "mac os x", version: "12.7.6", arch: "aarch64", family: "mac"

[basilevs]

<useUIThread>false</useUIThread> in tycho-surefire configuration for org.eclipse.oomph.setup.installer.tests
There a WARNING on Stdout:

***WARNING: Display must be created on main thread due to Cocoa restrictions. Use vmarg -XstartOnFirstThread

[merks]

Ah, this is bundling on the mac which I haven't been able to do for years because it's proven impossible to set up a mac virtual box on my Windows box. 😭

If I understand the flag correctly though, is says

Run tests in UI (true) or background (false) thread. Only applies to UI test harness.

So I'm not entirely sure that this determine on which thread the display is created. Did you try it?

The option itself only works on macos I believe because it fails like this on Windows:

$java -XstartOnFirstThread
Unrecognized option: -XstartOnFirstThread
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

I looked at what the Platform does and I see this

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/9a65698136e04a7eb758161de550f1ccbf4bc71e/eclipse-platform-parent/pom.xml#L1049-L1059

and they do this:

Setting <useUIThread> to true is certainly easier if that fixes the problem and works okay on the other platform!

[basilevs]

UseUIThread alone does not eliminate the warning.
I ended up adding both, and it seems to help:

--- a/plugins/org.eclipse.oomph.setup.installer.tests/pom.xml
+++ b/plugins/org.eclipse.oomph.setup.installer.tests/pom.xml
@@ -42,11 +42,12 @@
         <configuration>
           <argLine>-Doomph.setup.installer.mode=ADVANCED</argLine>
           <useUIHarness>true</useUIHarness>
-          <useUIThread>false</useUIThread>
+          <useUIThread>true</useUIThread>
           <product>org.eclipse.oomph.setup.installer.product</product>
           <application>org.eclipse.oomph.setup.installer.application</application>
           <testClass>org.eclipse.oomph.setup.installer.tests.InstallerTests</testClass>
           <forkedProcessTimeoutInSeconds>60</forkedProcessTimeoutInSeconds>
+          <argLine>-XstartOnFirstThread</argLine>
         </configuration>
       </plugin>

Now test application starts, but fails with:

[ERROR] Timeout of 60s exceeded. Process was killed

The same happens with useUIThread false.

[basilevs]

Here is a jstack of timeout.

1.txt

It was taken on a following source:

diff --git a/plugins/org.eclipse.oomph.setup.installer.tests/pom.xml b/plugins/org.eclipse.oomph.setup.installer.tests/pom.xml
index 8eebfce..250c751 100644
--- a/plugins/org.eclipse.oomph.setup.installer.tests/pom.xml
+++ b/plugins/org.eclipse.oomph.setup.installer.tests/pom.xml
@@ -47,6 +47,7 @@
           <application>org.eclipse.oomph.setup.installer.application</application>
           <testClass>org.eclipse.oomph.setup.installer.tests.InstallerTests</testClass>
           <forkedProcessTimeoutInSeconds>60</forkedProcessTimeoutInSeconds>
+          <argLine>-XstartOnFirstThread</argLine>
         </configuration>
       </plugin>