From 4b5d4433275a36389ddb496ef51bf8aa6b1f42bc Mon Sep 17 00:00:00 2001 From: Jay Varner Date: Mon, 20 Oct 2025 13:28:40 -0400 Subject: [PATCH 1/2] Include previously published label --- app/views/letters/_letter.json.jbuilder | 1 + spec/requests/letters_spec.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/app/views/letters/_letter.json.jbuilder b/app/views/letters/_letter.json.jbuilder index 90a567a..da58818 100644 --- a/app/views/letters/_letter.json.jbuilder +++ b/app/views/letters/_letter.json.jbuilder @@ -52,6 +52,7 @@ json.metadata do json.set! 'postcard_image', letter.postcard_image json.set! 'leaves_and_sides', [letter.leaves, letter.sides].join(', ') json.set! 'recipient', letter.recipient_list + json.set! 'previously_published', letter.letter_publisher&.label end json.repositories do diff --git a/spec/requests/letters_spec.rb b/spec/requests/letters_spec.rb index f752285..3ab9962 100644 --- a/spec/requests/letters_spec.rb +++ b/spec/requests/letters_spec.rb @@ -168,6 +168,7 @@ expect(letter.published).to be(true) get letter_url(letter), as: :json expect(json[:repositories]).to be_nil + expect(json[:metadata][:previously_published]).to eq(letter.letter_publisher.label) end it 'renders unpublished when requested from beckettapi' do From 7f07fc27a55bf6f3d3acbd1bcb3c3a0dca613f5c Mon Sep 17 00:00:00 2001 From: Jay Varner Date: Mon, 20 Oct 2025 13:37:11 -0400 Subject: [PATCH 2/2] Move previously published out of metadata --- app/views/letters/_letter.json.jbuilder | 3 ++- spec/requests/letters_spec.rb | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/views/letters/_letter.json.jbuilder b/app/views/letters/_letter.json.jbuilder index da58818..88bb053 100644 --- a/app/views/letters/_letter.json.jbuilder +++ b/app/views/letters/_letter.json.jbuilder @@ -52,7 +52,6 @@ json.metadata do json.set! 'postcard_image', letter.postcard_image json.set! 'leaves_and_sides', [letter.leaves, letter.sides].join(', ') json.set! 'recipient', letter.recipient_list - json.set! 'previously_published', letter.letter_publisher&.label end json.repositories do @@ -80,6 +79,8 @@ json.repositories do end end +json.set! 'previously_published', letter.letter_publisher.label if letter.letter_publisher.present? + json.set! 'publication_information', letter.publication_information if letter.publication_information.present? json.recipients do diff --git a/spec/requests/letters_spec.rb b/spec/requests/letters_spec.rb index 3ab9962..04ef8bf 100644 --- a/spec/requests/letters_spec.rb +++ b/spec/requests/letters_spec.rb @@ -168,7 +168,7 @@ expect(letter.published).to be(true) get letter_url(letter), as: :json expect(json[:repositories]).to be_nil - expect(json[:metadata][:previously_published]).to eq(letter.letter_publisher.label) + expect(json[:previously_published]).to eq(letter.letter_publisher.label) end it 'renders unpublished when requested from beckettapi' do