stuck on 100%

[eLBati]

Package: indicator-doom-cpu
Version: 1.0.0
Ubuntu 16.04

When I first start the indicator, it works correctly.
When i reboot the system, the indicator is stuck on 100%:

If I quit the indicator and start it again, it works correctly.

Thanks

[ebruck]

Are you still seeing this? If so, can you try a small code change for me?

[eLBati]

Hi @ebruck I am and I can

[ebruck]

@eLBati Can you make this change and see if the problem persists?

         cpu_load = int(CPUsage(interval=0.2).result)
-        image_idx = cpu_load / (100/(APP_NUM_IMAGES-1))
+        image_idx = cpu_load / (100.0/(APP_NUM_IMAGES-1))

[ebruck]

@eLBati Did it help?

[eLBati]

@ebruck I made the change, but, launching from CLI:

/usr/share/indicator-doom-cpu$ ./indicator-doom-cpu 
./indicator-doom-cpu:25: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded.
  from gi.repository import Gtk, GObject, GdkPixbuf
./indicator-doom-cpu:26: PyGIWarning: AppIndicator3 was imported without specifying a version first. Use gi.require_version('AppIndicator3', '0.1') before import to ensure that the right version gets loaded.
  from gi.repository import AppIndicator3 as AppIndicator
Traceback (most recent call last):
  File "./indicator-doom-cpu", line 132, in on_update_timer
    self.app_indicator.set_icon(APP_IMAGES[image_idx])
TypeError: list indices must be integers, not float

[ebruck]

@eLBati Sorry my mistake. Please patch like this:

         cpu_load = int(CPUsage(interval=0.2).result)
-        image_idx = cpu_load / (100/(APP_NUM_IMAGES-1))
+        image_idx = int(cpu_load / (100.0/(APP_NUM_IMAGES-1)))

[eLBati]

Ok , applied. Let's see what happens in the next days

[eLBati]

it happened again 😢

[ebruck]

Was this at system startup? I think here may be something weird going on when reading /proc/stat.
I'll look at putting in checks to prevent it from using a bad index.

[eLBati]

@ebruck yes, it happens at startup. Then, if I close and open again the indicator, it works correctly.
Maybe we can add a debug log ? (if it's not already there)