Skip to content

Show possible locations when specifying non-existant paths in github CLI integration #5068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flamefire wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Show possible locations when specifying non-existant paths in github CLI integration #5068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions easybuild/tools/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,10 +1073,11 @@ def _easyconfigs_pr_common(paths, ecs, start_branch=None, pr_branch=None, start_
ec_paths.append(path)

if non_existing_paths:
raise EasyBuildError(
"One or more non-existing paths specified: %s", ', '.join(non_existing_paths),
exit_code=EasyBuildExit.OPTION_ERROR
)
msg = "One or more non-existing paths specified: " + ', '.join(non_existing_paths)
found_ecs = {ec['spec'] for ec in ecs if os.path.basename(ec['spec']) in non_existing_paths}
if found_ecs:
msg += '\nDid you mean: ' + ', '.join(found_ecs)
raise EasyBuildError(msg, exit_code=EasyBuildExit.OPTION_ERROR)

if not any(paths.values()):
raise EasyBuildError("No paths specified", exit_code=EasyBuildExit.OPTION_ERROR)
Expand Down