Skip to content

identify new contributors in --list-prs (WIP) #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
migueldiascosta wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

identify new contributors in --list-prs (WIP) #2675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion easybuild/tools/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,13 +995,48 @@ def not_eligible(msg):
return res


def fetch_contributors(per_page=GITHUB_MAX_PER_PAGE, github_user=None):
"""
Fetch contributors
"""
parameters = {
'per_page': per_page,
'page': 1,
}

pr_target_account = build_option('pr_target_account')
pr_target_repo = build_option('pr_target_repo')

def contributors_url(gh):
"""Utility function to fetch data for PRs."""
return gh.repos[pr_target_account][pr_target_repo].contributors

contributors = []
while True:
status, contributor_data = github_api_get_request(contributors_url, github_user=github_user, **parameters)
if status != HTTP_STATUS_OK:
raise EasyBuildError("Failed to get contributor data from %s/%s (parameters: %s, status: %d %s)",
pr_target_account, pr_target_repo, parameters, status, contributor_data)
if not contributor_data:
break
contributors.extend([contributor['login'] for contributor in contributor_data])
parameters['page'] += 1

print_msg("Found %s contributors to %s/%s" % (len(contributors), pr_target_account, pr_target_repo))

return contributors


def list_prs(params, per_page=GITHUB_MAX_PER_PAGE, github_user=None):
"""
List pull requests according to specified selection/order parameters

:param params: 3-tuple with selection parameters for PRs (<state>, <sort>, <direction>),
see https://developer.github.com/v3/pulls/#parameters
"""

contributors = fetch_contributors()

parameters = {
'state': params[0],
'sort': params[1],
Expand All @@ -1024,7 +1059,10 @@ def pr_url(gh):

lines = []
for pr in pr_data:
lines.append("PR #%s: %s" % (pr['number'], pr['title']))
pr_txt = "PR #%s: %s" % (pr['number'], pr['title'])
if pr['user']['login'] not in contributors:
pr_txt += " [first contribution]"
lines.append(pr_txt)

return '\n'.join(lines)

Expand Down