From 208dd512cdabfb0c61fd6057a20fd5936b7eb675 Mon Sep 17 00:00:00 2001 From: Michael Lavers Date: Sat, 14 Feb 2026 16:58:48 -0800 Subject: [PATCH] Replace deprecated get_api_controller() with api_controller property The `@deprecated` for the `get_api_controller()` method is causing tons of warnings to be fired off because ninja_extra is still using `get_api_controller()`. --- ninja_extra/controllers/route/route_functions.py | 2 +- ninja_extra/details.py | 2 +- ninja_extra/operation.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ninja_extra/controllers/route/route_functions.py b/ninja_extra/controllers/route/route_functions.py index 0d9d78c4..d9f7b5c1 100644 --- a/ninja_extra/controllers/route/route_functions.py +++ b/ninja_extra/controllers/route/route_functions.py @@ -46,7 +46,7 @@ def __call__( *args: Any, **kwargs: Any, ) -> Any: - _api_controller = self.get_api_controller() + _api_controller = self.api_controller context = get_route_execution_context( request, temporal_response, diff --git a/ninja_extra/details.py b/ninja_extra/details.py index 1b183665..e5170bf2 100644 --- a/ninja_extra/details.py +++ b/ninja_extra/details.py @@ -31,7 +31,7 @@ def _validate_view_path_params(self) -> None: route_function: "RouteFunction" = ( self.view_func.get_route_function() ) - api_controller = route_function.get_api_controller() + api_controller = route_function.api_controller view_func = route_function.route.view_func diff --git a/ninja_extra/operation.py b/ninja_extra/operation.py index 61376e77..7b7ca88d 100644 --- a/ninja_extra/operation.py +++ b/ninja_extra/operation.py @@ -114,7 +114,7 @@ def _log_action( ) route_function = self._get_route_function() if route_function: - api_controller = route_function.get_api_controller() + api_controller = route_function.api_controller msg = ( f'"{request.method.upper() if request.method else "METHOD NOT FOUND"} - ' @@ -143,7 +143,7 @@ def get_execution_context( if hasattr(self.view_func, "get_route_function"): route_function: "RouteFunction" = self.view_func.get_route_function() - _api_controller = route_function.get_api_controller() + _api_controller = route_function.api_controller permission_classes = ( route_function.route.permissions or _api_controller.permission_classes # type: ignore[assignment] )