Skip to content

Consider tagging module "opengraph"? #8

@Rick-xuy

Description

@Rick-xuy

I found that packages, say github.com/dyatlov/go-opengraph/opengraph, are placed in submodule github.com/dyatlov/go-opengraph/opengraph instead of root module.

However, it seems that submodule github.com/dyatlov/go-opengraph/opengraph is not tagged. According to go docs, submodule should be tagged like relative-path-to-root/vX.X.X.
At now, when trying to import package github.com/dyatlov/go-opengraph/opengraph, downstream would depends on pseudo-version of module github.com/dyatlov/go-opengraph/opengraph.

github.com/dyatlov/go-opengraph/opengraph v0.0.0-20220524092352-606d7b1e5f8a

I think it is not very readable and difficult to upgrade. This is not conductive to version control either.
So, I propose whether it is possible to tag submodule properly. For example, opengraph/v0.0.1, opengraph/v1.0.1etc, so that other project can use tag to import this module in go.mod.

Another suggestion relates to issue #7. According to Go Modules wiki, specifying a require entry on newer version, at or after submodule being carved out, of root module github.com/dyatlov/go-opengraph in submodule's go.mod may avoid downstream's potential ambiguous import error.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions