Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Remove Valid Host Check as it does not cover all Domains #55

@dunklesToast

Description

@dunklesToast

I get the idea of the check but it actually prevents a user from using Hostnames, that are valid.
For example german company "Märklin" has the domain märklin.de which is totally valid and has an SSL certificate but your regex does not allow it.
Also, there are a lot of other special characters which are allowed on certain hostnames but not in your regex making the package kind of useless.
After a small local test I'd remove the test completely since Node just threws ENOTFOUND if the host does not exist.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions