Skip to content

Add a configurable option for importing CompareImages  #471

@jprestop

Description

@jprestop

Describe the Enhancement

When running test/run_all_nco.sh or test/pythest on WCOSS2, the code errors out with:

ModuleNotFoundError: No module named 'imutils'

These failures were not present in the beta5 installation, and 'imutils' is not allowed on WCOSS2.

It appears this situation came about from this PR Feature 461 make compare images configurable #467 where the line "from metcalcpy.compare_images import CompareImages" was uncommented from approximately 20 files. CompareImages in METcalcpy imports 'imutils'. It looks like the PR intended to make the use of CompareImages configurable by an environment variable used in conftest.py. But, conftest.py is not what is used to test on WCOSS2, instead run_all_nco.sh is used. However, when running pytest the 'imutils' errors are still present.

The code was commented out again in this PR 461 revert compare images changes #472.

We need a configurable option so that the CompareImages isn't imported on WCOSS2, but could be elsewhere if desired.

Time Estimate

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

None

Funding Source

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects###

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select METplotpy-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)##

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplotpy-X.Y.Z Development project for development toward the next official release
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions