Skip to content

Action of mpa.compress() without arguments #35

@milan-hl

Description

@milan-hl

I expected that mpa.compress() without arguments would not perform compression except maybe ensure normalization. This would be useful in order to make compression optional: No arguments cause no compression to be performed.

However, both mpa.compress() and mpa.compression() perform SVD compression without bdim and relerr, i.e. they truncate singular values which are equal to zero. This does not occur frequently. In many cases, this will not reduce the bond dimension by more than a simple mpa.normalize() and CPU time is wasted.

I suggest to change change the two methods to not run SVD compression if method='SVD' is not specified. @dseuss, do you agree?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions