Skip to content

Commit 514eacb

Browse files
committed
push the new controller image
1 parent b1fcf44 commit 514eacb

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# CDNOS Image URL to use to test CDNOS CRD Deployment
22
CDNOS_IMG ?= registry.dev.drivenets.net/devops/cdnos_pr_61596:19.1.0.1_priv.61596.59ad5662f25a3760114008c0e51c2ef1b583ae7e
33
# Image URL to use all building/pushing image targets
4-
CONTROLLER_IMG ?= public.ecr.aws/dn/cdnos-controller:1.7.1
4+
CONTROLLER_IMG ?= public.ecr.aws/dn/cdnos-controller:1.7.2
55
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
66
ENVTEST_K8S_VERSION = 1.28.0
77

config/manager/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ kind: Kustomization
55
images:
66
- name: controller
77
newName: public.ecr.aws/dn/cdnos-controller
8-
newTag: "1.7.1"
8+
newTag: "1.7.2"

config/manifests/manifest.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ spec:
576576
- --leader-elect
577577
command:
578578
- /manager
579-
image: public.ecr.aws/dn/cdnos-controller:1.7.1
579+
image: public.ecr.aws/dn/cdnos-controller:1.7.2
580580
livenessProbe:
581581
httpGet:
582582
path: /healthz

internal/controller/cdnos_controller.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,7 @@ func (r *CdnosReconciler) reconcilePod(ctx context.Context, cdnos *cdnosv1.Cdnos
188188
pod.Spec.InitContainers[0].Image = cdnos.Spec.InitImage
189189
pod.Spec.InitContainers[0].Args = []string{fmt.Sprintf("%d", cdnos.Spec.InterfaceCount), fmt.Sprintf("%d", cdnos.Spec.InitSleep)}
190190
pod.Spec.Containers[0].Command = []string{cdnos.Spec.Command}
191-
//pod.Spec.Containers[0].Args = append(cdnos.Spec.Args, fmt.Sprintf("--target=%s", cdnos.Name))
192-
//pod.Spec.Containers[0].Args = append(cdnos.Spec.Args, "1000")
193191
pod.Spec.Containers[0].Env = cdnos.Spec.Env
194-
//pod.Spec.Containers[0].Resources = cdnos.Spec.Resources
195192
Limits := CombineResourceRequirements(cdnos.Labels, cdnos.Spec.Resources)
196193
pod.Spec.Containers[0].Resources = Limits
197194

@@ -404,6 +401,7 @@ func checkFieldExists(env []corev1.EnvVar, fieldName string) bool {
404401
return false
405402
}
406403

404+
// This is the function that is responsible for organizing the resource requirements and limits from the labels
407405
func CombineResourceRequirements(kv map[string]string, req2 corev1.ResourceRequirements) corev1.ResourceRequirements {
408406
result := corev1.ResourceRequirements{
409407
Requests: map[corev1.ResourceName]resource.Quantity{},
@@ -437,6 +435,7 @@ func CombineResourceRequirements(kv map[string]string, req2 corev1.ResourceRequi
437435
return result
438436
}
439437

438+
// This function is responsible for reconciling the service
440439
func (r *CdnosReconciler) reconcileService(ctx context.Context, cdnos *cdnosv1.Cdnos) error {
441440
var service corev1.Service
442441
svcName := fmt.Sprintf("service-%s", cdnos.Name)

0 commit comments

Comments
 (0)