Skip to content

Fix issues with clean_up_results #34

@dr-rodriguez

Description

@dr-rodriguez

The clean_up_results function is meant to check that observations in the returned MAST query are indeed in the field of view when the target was present. However, there are many bugs with it right now that effectively remove valid results and also undos some of what it's trying to do.

Here's a list of some of the problems:

  • regions doesn't have intersection of polygons yet so valid observations are missed
  • the mid point for observations like TESS can be days away from the target location
  • the _detail_check function is effectively re-adding most of what it clears

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglarge-issueComplex or time-consuming issues

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions