Skip to content

Bugs in the auto implementation for #140 #294

@innokenty

Description

@innokenty

Codebase

Original feature issue: #140
Golden implementation PR: #163
Golden implementation branch: task/#140-Email-Notifications-with-Read-Tracking

Auto-generated implementation branch: toloka-agent/140-auto
Auto implementation with golden tests branch: toloka-agent/140-auto-golden-test

Failed Golden Tests

[ERROR] Failures: 
[ERROR]   EmailNotificationIntegrationTest.shouldAllowTrackingEndpointWithoutAuthentication:180 [HTTP status code] 
expected: 200
 but was: 401
[ERROR]   EmailNotificationIntegrationTest.shouldBeIdempotentWhenCalledMultipleTimes:277 [HTTP status code] 
expected: 200
 but was: 401
[ERROR]   EmailNotificationIntegrationTest.shouldCreateNotificationEvenWhenEmailSendingFails:220 [delivery_status should be FAILED after email send failure] 
expected: "FAILED"
 but was: "PENDING"
[ERROR]   EmailNotificationIntegrationTest.shouldEscapeHtmlInEmailContent:377 
Expecting actual:
  "<html>
<body>
  <h2>FEATURE CREATED</h2>
  <pre>{"actor":"alice","featureCode":"IDEA-114","action":"created","title":"<script>alert('XSS')</script>Malicious Feature","status":"NEW"}</pre>
  <p><a href="http://localhost:8081/features/IDEA-114">View Details</a></p>
  <img src="http://localhost:8081/api/notifications/3992731a-4cd9-40b6-8c33-7fc6def52e5f/read" width="1" height="1" style="display:none" alt="" />
</body>
</html>
"
not to contain:
  "<script>"

[ERROR]   EmailNotificationIntegrationTest.shouldMarkNotificationAsReadWhenTrackingPixelIsLoaded:149 [HTTP status code] 
expected: 200
 but was: 401
[ERROR]   EmailNotificationIntegrationTest.shouldReturn400ForInvalidUuidFormat:251 [HTTP status code] 
expected: 400
 but was: 401
[ERROR]   EmailNotificationIntegrationTest.shouldReturn404ForNonExistentNotificationId:239 [HTTP status code] 
expected: 404
 but was: 401
[ERROR]   EmailNotificationIntegrationTest.shouldReturnValidGifImage:341 [HTTP status code] 
expected: 200
 but was: 401
[INFO] 
[ERROR] Tests run: 75, Failures: 8, Errors: 0, Skipped: 0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions