dateTime bug gives java error on valid xml datatype content

[solfeggietto]

noark-extraction-validator gives java error on vaid dateTime variants like:
<avsluttetDato>2018-03-26T09:20:45.5301805+02:00</avsluttetDato>

While the standard formatted dateTime with no extended decimals or timezone is handled correctly with no java error, like:
<opprettetDato>2004-11-04T00:00:00</opprettetDato>

This applies to all versions including v0.2.0, v0.6.0 and the different SNAPSHOT betaversion branches of v0.7.0.

May be cause by a limited handling of dateTime formatting
..\noark-extraction-validator\src\main\java\com\documaster\validator\storage\database\DatabaseStorage.java

`... .package com.documaster.validator.storage.database;

public class DatabaseStorage extends Storage {

private static final Logger LOGGER = LoggerFactory.getLogger(DatabaseStorage.class);

private static final String[] INCOMING_DATE_PATTERNS = new String[] {
		"yyyy-MM-dd'T'HH:mm:ss.SSS", "yyyy-MM-dd'T'HH:mm:ss", "yyyy-MM-dd" };`

Decom consol logg showing indicates "invalid datetime format", but as shown abote it likeley is too naroow format handling by the java code implementation

"E:\arkiv-work\1567\1567_1_E-1567-2018-0001\repository_operations\noark-extraction-validator\20191211_23.05.4944" -ignore-non-compliant-xml
Exception in thread "Thread-2" com.documaster.validator.exceptions.StorageException: Storage writer encountered an unexpected error
at com.documaster.validator.storage.core.StorageWriter.run(StorageWriter.java:77)
Caused by: java.sql.SQLDataException: data exception: invalid datetime format

[solfeggietto]

Additional note: all valid XML v1.0 dateTime variants should be handled by noark-extractor-valdiator. And if the code itself fails to handle a dateTime it should not give java-error but instead log the incident, in this case report it as a dateTime error (even if its not an XMl dateTime error, this code things it is so and should report it accordingly and move on running and not give java-error).

Examples of allowed dateTime formatting i XML v1.0:
https://www.w3schools.com/xml/schema_dtypes_date.asp

startdate>2002-05-30T09:00:00</startdate> <startdate>2002-05-30T09:30:10.5</startdate> <startdate>2002-05-30T09:30:10Z</startdate> <startdate>2002-05-30T09:30:10-06:00</startdate> <startdate>2002-05-30T09:30:10+06:00</startdate>

[solfeggietto]

Accidently closed this Issue - my intention was to add a note :-)
Reopened!

[solfeggietto]

This may be caused by arkivuttrekk.xml having invalid startDate and/or endDate.

Any value of date or dateTime expected by noark-extractor-validator should be prequalified and if incorrect be replaced by a dummy valid element, the incident should be logged in the appropriate section in the resulting Excel or XML file and validation operation should continue.

If for some reason the validation must stop, it must present the reason for the halt, where the date or dateTime element is and what value it holds that is invalid.

We must avvoid any Java error or undocumented position and value with the cause of the error.
After all this is a validator which main purpose is automating the error report of a noark extraction to avoid leaving the user unknown of the cause of an error.

<content> <additionalElements> <additionalElement name="archivalPeriod"> <properties> <property name="startDate"> <!-- ÅÅÅÅ-MM-DD --> <!-- <value>2016-09-27</value> --> <value>[ÅÅÅÅ-MM-DD]</value> </property> <property name="endDate"> <!-- ÅÅÅÅ-MM-DD --> <!-- <value>2016-09-27</value> --> <value>[ÅÅÅÅ-MM-DD]</value> </property> </properties> </additionalElement> </additionalElements> </content>