This repository was archived by the owner on Apr 22, 2022. It is now read-only.
Fixes entity not being removed from ES #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added objectManager accessors instead of entityManager accessors - entityManager accessors are marked as deprecated
…dentMappingDriver
Fixed race condition when creating index aliases
Inheritance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this should fix the bug I have experienced when removing entities. Aparently, doctrine after flushing the remove to entity sets its ID to NULL, and since the search manager tracks the entity as reference, it sends the request to delete the entity with ID NULL to elastic search. Cloning the entity should fix this problem.
BEFORE:
AFTER:
Also, sorry if the pull request is wrong, doing it for the first time:) It should only change OrmSearchableListener, line 67, by ading clone in front of $oEntity