Use current context by default on set subcommands

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>

Author: simonferquel

cli/command/context/set.go

@@ -1,6 +1,7 @@
 package context
 
 import (
+	"errors"
 	"github.com/docker/cli/cli"
 	"github.com/docker/cli/cli/command"
 	"github.com/spf13/cobra"
@@ -21,3 +22,13 @@ func newSetCommand(dockerCli command.Cli) *cobra.Command {
 	)
 	return cmd
 }
+
+func contextNameFromArgsOrCurrent(args []string, dockerCli command.Cli) (string, error) {
+	if len(args) > 0 {
+		return args[0], nil
+	}
+	if dockerCli.CurrentContext() == command.ContextDockerHost {
+		return "", errors.New("no context in use, please specify the context to modify")
+	}
+	return dockerCli.CurrentContext(), nil
+}

cli/command/context/setdocker.go

@@ -11,11 +11,14 @@ import (
 func newSetDockerEndpointCommand(dockerCli command.Cli) *cobra.Command {
 	opts := &dockerEndpointOptions{}
 	cmd := &cobra.Command{
-		Use:   "docker-endpoint [OPTIONS] CONTEXT",
+		Use:   "docker-endpoint [OPTIONS] [CONTEXT]",
 		Short: "Reset the docker endpoint of a context",
-		Args:  cli.ExactArgs(1),
+		Args:  cli.RequiresMaxArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			name := args[0]
+			name, err := contextNameFromArgsOrCurrent(args, dockerCli)
+			if err != nil {
+				return err
+			}
 			contextMetadata, err := dockerCli.ContextStore().GetContextMetadata(name)
 			if err != nil {
 				return err

cli/command/context/setkubernetes.go

@@ -11,11 +11,14 @@ import (
 func newSetKubernetesEndpointCommand(dockerCli command.Cli) *cobra.Command {
 	opts := &kubernetesEndpointOptions{}
 	cmd := &cobra.Command{
-		Use:   "kubernetes-endpoint <context> [options]",
+		Use:   "kubernetes-endpoint [OPTIONS] [CONTEXT]",
 		Short: "Reset the kubernetes endpoint of a context",
 		Args:  cli.ExactArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			name := args[0]
+			name, err := contextNameFromArgsOrCurrent(args, dockerCli)
+			if err != nil {
+				return err
+			}
 			contextMetadata, err := dockerCli.ContextStore().GetContextMetadata(name)
 			if err != nil {
 				return err

cli/command/context/setoptions.go

@@ -8,15 +8,19 @@ import (
 
 func newSetStackOrchestratorCommand(dockerCli command.Cli) *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "stack-orchestrator CONTEXT ORCHESTRATOR",
+		Use:   "stack-orchestrator [CONTEXT] ORCHESTRATOR",
 		Short: "Set the default stack orchestrator of a context",
-		Args:  cli.ExactArgs(2),
+		Args:  cli.RequiresRangeArgs(1, 2),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			orchestrator, err := command.NormalizeOrchestrator(args[1])
+			name, err := contextNameFromArgsOrCurrent(args[:len(args)-1], dockerCli)
+			if err != nil {
+				return err
+			}
+			orchestrator, err := command.NormalizeOrchestrator(args[len(args)-1])
 			if err != nil {
 				return err
 			}
-			return setContextLevelOption(dockerCli, args[0], func(dc *command.DockerContext) {
+			return setContextLevelOption(dockerCli, name, func(dc *command.DockerContext) {
 				dc.StackOrchestrator = orchestrator
 			})
 		},
@@ -26,12 +30,16 @@ func newSetStackOrchestratorCommand(dockerCli command.Cli) *cobra.Command {
 
 func newSetDescriptionCommand(dockerCli command.Cli) *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "description CONTEXT DESCRIPTION",
+		Use:   "description [CONTEXT] DESCRIPTION",
 		Short: "Set description of a context",
 		Args:  cli.ExactArgs(2),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			return setContextLevelOption(dockerCli, args[0], func(dc *command.DockerContext) {
-				dc.Description = args[1]
+			name, err := contextNameFromArgsOrCurrent(args[:len(args)-1], dockerCli)
+			if err != nil {
+				return err
+			}
+			return setContextLevelOption(dockerCli, name, func(dc *command.DockerContext) {
+				dc.Description = args[len(args)-1]
 			})
 		},
 	}