Specify an alternative location for access class

[storm255]

Thank you for your efforts with this gem.

I may be missing something obvious, but ideally I would like to arrange my access classes into another folder as they grow. I have tried to use the source_class method on the originating class but without success.

Playing with the gem I managed to get what I needed working temporarily by adding another line to the registry

# vendor/gems/allowy-1.0.0/lib/allowy/registry.rb

    def access_control_for(subject)
      # Local modification: Allow specifying the access class directly
      clazz = subject.class.authorisation_class if subject.class.respond_to?(:authorisation_class)

and then just adding a direct reference to the target access class with

# models/actions/cancel_deposit.rb

  def self.authorisation_class
    Authorisations::CancelDepositAccess
  end

# models/authorisations/cancel_deposit_access.rb
class Authorisations::CancelDepositAccess
  include Allowy::AccessControl
  def cancel_deposit?(cd)
    context.signed_in?
  end
end

Is this heading in the right direction or is there a way to work with the library?

Cheers.

[dnagir]

@storm255 I'll get back to you next week on this. Sorry, a little busy now.
Ping me again if I'll forget to.

But your use-case is a very good one I'd like to support.

This should be supported out of the box without any overrides.
It currently isn't because Registry#class_for accepts just class name only without the module.

So all we need to do is to modify the following lines to pass fully qualified names (or simply actual classes):

• allowy/lib/allowy/registry.rb

  Line 18 in 37a85eb

  clazz = class_for subject.class.source_class.name if subject.class.respond_to?(:source_class)

• allowy/lib/allowy/registry.rb

  Line 21 in 37a85eb

  clazz = class_for subject.class.name unless clazz

• allowy/lib/allowy/registry.rb

  Line 24 in 37a85eb

  clazz = class_for subject.name if !clazz && subject.is_a?(Class)

That should be fairly simple to do so if you can submit a PR then it would be great.
Otherwise I'll eventually, hopefully do it 😄