Fan Mode resets to Auto on Restart and Performance Mode Change

[NamitBhutani]

Fan Mode resets to Auto (from Advanced Fan Control) on Restart and Performance Mode Change, I have to retoggle (turn off then on) Advanced Fan Control everytime I change performance modes.

Also the Fan Mode setting to Advanced does not persist reboots, even though other settings like Performance Modes do.

All this only happens if I have msi-ec installed, without it, it works fine.

[mutchiko]

@NamitBhutani what version of MCC are you using?

[NamitBhutani]

0.5.0

[mutchiko]

advanced fan mode is only activated on performance mode, and in msi laptops, fan /performance modes are reset after sleep/restart.

ll this only happens if I have msi-ec installed, without it, it works fine.

because it actually report real time changes.

for now, i highly recommend building from source (steps are in readme).

[NamitBhutani]

Advanced fan mode is only activated on performance mode, and in MSI laptops, fan/performance modes are reset after sleep/restart.

I guess that is the expected behavior (according to MSI Center at least), but according to my testing, I can use advanced fan mode to change the RPM in any mode. Each mode has a set maximum RPM the fans can hit, and using advanced mode I can set percentages of that RPM.

Because it actually reports real time changes.

Regarding this, I think I figured out the bug in the code which was causing this issue when using msi-ec (keep in mind I didn't compile and test, since I didn't have the time to do so). The issue could be Operate::setUserMode calling msiEcHelper.setFanMode with fan_mode::advanced_fan_mode in all cases.

[mutchiko]

according to MSI Center at least

you tested on windows too?

using advanced mode I can set percentages of that RPM.

this differs between models, so what works for you might not work for others.

as for settings not persisting, this is a thing i need to look into, i already fixed it accidentally once.

[NamitBhutani]

you tested on windows too?

Well, technically MSI Center only allows me to use Advanced Fan Control in User mode.
And regarding settings resetting, ig it might be true that they reset on boot, but on Windows, MSI Center runs on startup for me so it be automatically applying settings.

[mutchiko]

on Windows, MSI Center runs on startup for me so it be automatically applying settings

and MCC does that already, i think i have figured out the issue already, so i will be looking into a fix.

[NamitBhutani]

on Windows, MSI Center runs on startup for me so it be automatically applying settings

and MCC does that already, i think i have figured out the issue already, so i will be looking into a fix.

I don't think it does that when we have msi-ec installed, without that using just the helper class, yes it does.

[mutchiko]

it saves performance mode not fan mode

[Jiogo18]

I just noticed the issue. Operate::setUserMode always sets auto, whether advanced is checked or not.

MControlCenter/src/operate.cpp

Line 383 in 7bd388b

fan_mode fanMode = fan_mode::auto_fan_mode;

To prove it, simply use advanced_fan_mode instead. Now, it will reset to advanced.

@mutchiko did you start something? Operate doesn't have access to the advanced checkbox, so we may want to either to store the state, or move this setFanMode logic to the mainwindow.

[mutchiko]

did you start something?

@Jiogo18 i looked into the issue in the past, and came to the conclusion that the settings file "MControlCenter" in ~/.config stores the state of advanced fan mode but doesn't store other fan modes, like auto (which gets applied automatically) and silent, with the latter being reset to auto after wake up resulting in a weird combo of shift mode + fan mode in some cases.

[MainWindow]
Height=480
Width=580

[Settings]
FnSuperSwap=false
UsbPowerShare=false
UserMode=super_battery_mode
fan1SpeedSettings=0|29|48|54|60|70|85
fan1TempSettings=55|64|73|76|82|88
fan2SpeedSettings=11|23|37|54|60|70|85
fan2TempSettings=55|60|65|70|75|80
fanModeAdvanced=false

Advanced fan mode alone needs a good discussion because it behaves differently on each device, for example, on your device, you can change the fan curve for the gpu fan even if cat /sys/devices/platform/msi-ec/fan_mode says silent

[Jiogo18]

It's not only about saving fan mode. When changing shift/user mode, advanced is replaced by auto, whether it is checked or not.

Can shift mode and fan mode be stored? I have a few design proposals, going to a suggestion #274.