Skip to content

onActivityResult - onRequestPermissionsResult support in Activity/Controller class #61

@brcbydr

Description

@brcbydr

Hi @dmdevgo ,

Sorry for disturbing again but this is important.

RxPm already handles CREATED, BINDED, RESUMED, PAUSED, UNBINDED, DESTROYED.
But onActivityResult and onRequestPermissionsResult not supported. Function results like login etc should handled in onActivityResult. And with RxPm, business logic can not be in Controller or Activity, it should be in presenter.

Conductor support onActivityResult is like that: (https://github.com/bluelinelabs/Conductor/blob/develop/conductor/src/main/java/com/bluelinelabs/conductor/Router.java)

Implementation is like below:
`class MainActivity : AppCompatActivity() {

private lateinit var router: Router

override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
    super.onActivityResult(requestCode, resultCode, data)
    router.onActivityResult(requestCode, resultCode, data)
}

}`

I think it makes sense to support onActivityResult in PresentationModel according to Router.
What do you think about that?

Thanks in advance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions