From 97ef4c77ba0e623487b392695fed4cc4d3785e28 Mon Sep 17 00:00:00 2001 From: Daniel Juarez <34030545+djuarezg@users.noreply.github.com> Date: Mon, 25 May 2020 17:34:33 +0200 Subject: [PATCH] mantisbt: Handle duplicates with no relationships Currently, bugs with duplicates cause AttachCentosBugs action to fail as it asumes duplicate relationships cannot be empty and iterates over a NoneType instead of using a list. This can be observed with https://bugs.centos.org/view.php?id=11115. This commit allows to use an empty list if there are no relationships. --- src/pyfaf/bugtrackers/mantisbt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pyfaf/bugtrackers/mantisbt.py b/src/pyfaf/bugtrackers/mantisbt.py index 6c6ea8aa7..c0bbbc038 100644 --- a/src/pyfaf/bugtrackers/mantisbt.py +++ b/src/pyfaf/bugtrackers/mantisbt.py @@ -153,7 +153,7 @@ def preprocess_bug(self, bug): return None if bug_dict["resolution"] == "DUPLICATE": - for relationship in bug.relationships: + for relationship in bug.relationships or []: if relationship.type.name == "duplicate of": bug_dict["dupe_id"] = relationship.target_id break