Skip to content

Commit f795c8d

Browse files
committed
fix: allow task dropdown to close on outside click
Remove stopPropagation() calls from Editor and Header components that were preventing click events from reaching Buefy's document-level listener for closing dropdowns. Also remove redundant can-close prop from Tasks dropdown since the default behavior already includes closing on outside clicks.
1 parent e770aeb commit f795c8d

File tree

3 files changed

+3
-11
lines changed

3 files changed

+3
-11
lines changed

client/src/components/Editor.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<div class="editor" ref="editorContainer" @click="prevent($event)"></div>
2+
<div class="editor" ref="editorContainer"></div>
33
</template>
44

55
<script setup lang="ts">
@@ -563,10 +563,6 @@ const handleDropEvent = (event: DragEvent, view: EditorView): boolean => {
563563
return true;
564564
};
565565
566-
const prevent = ($event: Event) => {
567-
$event.stopPropagation();
568-
};
569-
570566
const save = () => {
571567
emit('saveShortcut');
572568
return true;

client/src/components/Header.vue

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<div class="header-wrapper light-white" @click="prevent($event)">
2+
<div class="header-wrapper light-white">
33
<div class="main-header">
44
<!-- Left section - sidebar toggle and actions -->
55
<div class="header-left">
@@ -181,10 +181,6 @@ const goToSearch = () => {
181181
router.push({ name: 'search' }).catch((_err) => {});
182182
};
183183
184-
const prevent = ($event: Event) => {
185-
$event.stopPropagation();
186-
};
187-
188184
const prevDay = () => {
189185
const date = subDays(sidebar.date || new Date(), 1);
190186
router.push({ name: 'day-id', params: { id: format(date, 'MM-dd-yyyy') } });

client/src/components/Tasks.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<div class="level-item alt-button">
3-
<b-dropdown aria-role="list" :can-close="['escape', 'outside']">
3+
<b-dropdown aria-role="list">
44
<template #trigger>
55
<b-tooltip
66
label="Tasks"

0 commit comments

Comments
 (0)