Skip to content

DGI9-637: More specific logging for failed enqueues. #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nchiasson-dgi merged 2 commits into from
Jan 20, 2026
Merged

DGI9-637: More specific logging for failed enqueues. #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed23a0
More specific logging for failed enqueues.
adam-vessey Jan 5, 2026
243593a
Add additional context to the exception message.
adam-vessey Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/MigrateBatchExecutable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,11 @@ public function prepareBatch() {
'finished' => [$this, 'finishBatch'],
];
}
else {
throw new \Exception('Migration failed.');

if ($this->enqueueException) {
throw new \Exception("Migration ({$this->migration->id()}) failed. Wrapped exception: {$this->enqueueException->getMessage()}", previous: $this->enqueueException);
}
throw new \Exception("Migration ({$this->migration->id()}) failed.");
}

/**
Expand All @@ -180,6 +182,13 @@ public function teardownMigration() {
$this->migration->setStatus(MigrationInterface::STATUS_IDLE);
}

/**
* Stash any exception encountered during enqueueing, so it can be reported.
*
* @var \Exception|null
*/
protected ?\Exception $enqueueException = NULL;

/**
* Populate the target queue with the rows of the given migration.
*
Expand Down Expand Up @@ -218,6 +227,7 @@ protected function enqueue() {
),
'error'
);
$this->enqueueException = $e;

return MigrationInterface::RESULT_FAILED;
}
Expand All @@ -232,6 +242,7 @@ protected function enqueue() {
$this->message->display(
$this->t('Migration failed with source plugin exception: @e', ['@e' => $e]), 'error');
$this->migration->setStatus(MigrationInterface::STATUS_IDLE);
$this->enqueueException = $e;
return MigrationInterface::RESULT_FAILED;
}

Expand Down
Loading