From 0524948e6ad5b7ae4a54438b2f7d2b1bf19046da Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 7 Nov 2025 18:43:43 +0100 Subject: [PATCH 1/4] DEV: Clean up outdated docs, ignore entries, rake task A followup to #368 --- .gitignore | 2 -- DEV.md | 7 ------- Rakefile | 2 +- 3 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 DEV.md diff --git a/.gitignore b/.gitignore index 112d8f88..b6beeeb0 100644 --- a/.gitignore +++ b/.gitignore @@ -16,7 +16,5 @@ test/tmp test/version_tmp tmp *.swp -.rubocop-https---raw-githubusercontent-com-discourse-discourse-master--rubocop-yml .byebug_history node_modules/ -yarn.lock diff --git a/DEV.md b/DEV.md deleted file mode 100644 index 6440f763..00000000 --- a/DEV.md +++ /dev/null @@ -1,7 +0,0 @@ -### How to Publish to NPM - -1. First, edit `package.json` and bump the version. - -2. Log in to npm `yarn login` - -3. Publish: `yarn publish` diff --git a/Rakefile b/Rakefile index 384510f7..da348e92 100644 --- a/Rakefile +++ b/Rakefile @@ -35,7 +35,7 @@ end namespace :jasmine do desc "Run Jasmine tests in headless mode" task 'ci' do - if !system("npx jasmine-browser-runner runSpecs") + if !system("pnpm jasmine-browser-runner runSpecs") exit 1 end end From f1f9d7e301f396d08dce8a6e79ab189ac0b0261e Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 7 Nov 2025 18:59:24 +0100 Subject: [PATCH 2/4] test --- Rakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Rakefile b/Rakefile index da348e92..384510f7 100644 --- a/Rakefile +++ b/Rakefile @@ -35,7 +35,7 @@ end namespace :jasmine do desc "Run Jasmine tests in headless mode" task 'ci' do - if !system("pnpm jasmine-browser-runner runSpecs") + if !system("npx jasmine-browser-runner runSpecs") exit 1 end end From 65681e4bb99732dac96d9b09785c7a31e59f19f5 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 7 Nov 2025 19:02:25 +0100 Subject: [PATCH 3/4] rev --- Rakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Rakefile b/Rakefile index 384510f7..da348e92 100644 --- a/Rakefile +++ b/Rakefile @@ -35,7 +35,7 @@ end namespace :jasmine do desc "Run Jasmine tests in headless mode" task 'ci' do - if !system("npx jasmine-browser-runner runSpecs") + if !system("pnpm jasmine-browser-runner runSpecs") exit 1 end end From 178458d5742d5d5036b1d59b886e7e509cf0a7d5 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 7 Nov 2025 19:02:36 +0100 Subject: [PATCH 4/4] add pnpm to tests job --- .github/workflows/ci.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6e4ed8dc..f76c55cf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -79,6 +79,16 @@ jobs: ruby-version: ${{ matrix.ruby }} bundler-cache: true + - uses: pnpm/action-setup@v4 + + - uses: actions/setup-node@v6 + with: + node-version: "24" + cache: "pnpm" + + - name: Pnpm install + run: pnpm install + - name: Tests env: TESTOPTS: --verbose