Skip to content

Change status text by setting? #28

@mathomp4

Description

@mathomp4

After you fixed my issue #26, we are now testing out using required labels in our system. Huzzah!

But now I have a question for the devels. Would it be possible to have the status text on github, which I controlled by, I think:

required-labels/utils.py

Lines 46 to 51 in 0fddb9c

def create_status_json(self, required_any, required_all, banned):
passes_label_requirements = self.validate_labels(required_any, required_all, banned)
if passes_label_requirements:
description = "Label requirements satisfied."
else:
description = "Label requirements not satisfied."

be dynamic and changeable in the Heroku settings? It would be nice if the check returns a failure that it could say:

Label requirements not satisfied: You must add at least one of label1, label2, label3

where the label1, etc. are the required-any labels (or whatever) we've decided to be required.

Now, I'm going to add a PR template explaining this so they know they need a label, but as is well known, if a template has comments, they can be easily ignored.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions