From c81e0d4b0c90a76b35ffc5a0d016fdec67e0ef7b Mon Sep 17 00:00:00 2001 From: Jose Mestizo Date: Wed, 26 Mar 2025 11:01:38 -0600 Subject: [PATCH] Fix creating gzip reader Existing code always returns an error when creating a reader for gzip encoded content. 2025-03-22 20:59:56.000 ERROR: 2025/03/22 20:59:56 /var/tmp/aiven-rpm-build/rpmbuild/BUILD/do-agent-3.17.0/_build/src/github.com/digitalocean/do-agent/pkg/collector/scraper.go:137: collection failed for "dodbaas": failed to create gzip reader: %!w() --- pkg/collector/scraper.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/collector/scraper.go b/pkg/collector/scraper.go index 4fc864e5..d0908df2 100644 --- a/pkg/collector/scraper.go +++ b/pkg/collector/scraper.go @@ -166,7 +166,11 @@ func (s *Scraper) readStream(ctx context.Context) (r io.ReadCloser, outerr error } reader, err := gzip.NewReader(bufio.NewReader(resp.Body)) - return reader, fmt.Errorf("failed to create gzip reader: %w", err) + if err != nil { + return nil, fmt.Errorf("failed to create gzip reader: %w", err) + } + + return reader, nil } // Describe describes this collector