Tech debt: Remove plan-fallback.json once plan specification is production-ready
Context
The plan specification (local-plan, supplementary-plan, minerals-plan, waste-plan) is not yet in a production-ready format in the specification table. As a temporary measure, plan-fallback.json was added to config/ and checkSpecificationFallback middleware overrides req.specification with this local file instead.
What needs doing
Once the plan specification is promoted to a production-ready format in the specification table:
- Remove
config/plan-fallback.json
- Remove
checkSpecificationFallback from processSpecificationMiddlewares
- Remove the
readFileSync import and planFallback / PLAN_FALLBACK_DATASETS_JSON constants from common.middleware.js
Acceptance criteria
- Plan datasets (
local-plan, supplementary-plan, minerals-plan, waste-plan) resolve their specification directly from the DB via the existing fetchSpecification → pullOutDatasetSpecification pipeline
- No local fallback file in
config/
Tech debt: Remove
plan-fallback.jsononce plan specification is production-readyContext
The plan specification (
local-plan,supplementary-plan,minerals-plan,waste-plan) is not yet in a production-ready format in the specification table. As a temporary measure,plan-fallback.jsonwas added toconfig/andcheckSpecificationFallbackmiddleware overridesreq.specificationwith this local file instead.What needs doing
Once the plan specification is promoted to a production-ready format in the specification table:
config/plan-fallback.jsoncheckSpecificationFallbackfromprocessSpecificationMiddlewaresreadFileSyncimport andplanFallback/PLAN_FALLBACK_DATASETS_JSONconstants fromcommon.middleware.jsAcceptance criteria
local-plan,supplementary-plan,minerals-plan,waste-plan) resolve their specification directly from the DB via the existingfetchSpecification→pullOutDatasetSpecificationpipelineconfig/