Summary Description
When adding an endpoint or assigning entities to an endpoint, if the reference has a :(colon) in the reference then the it is process as prefix:reference
For e.g. if the reference value is DA:20/21=S106:001:20/0284/FUL then the assign-entities process considers it has prefix:reference
Implement a fix such that the entire value is considered as a reference and the value isn't split.
Technical Approach
-
The entity reference phase for some reason attempts to split the curie from the reference column. This wouldn't be a problem if the reference wasn't able to contain ':' itself. because it is able to contain ':' we are seeing that some references are being split when they shouldn't
-
Are there are examples in our code base where this is being used? might need to add some logging to check as we might not know what we're breaking if we turn it off. Check a random set of collections including:
- organisation
- brownfield-land
- tree preservation order
-
once we have checked a sample of collections and if we see no examples of where this is used we should look at adjusting the phase (not just putting a hot fix on it) we should only attempt to use the reference prefix if sef.prefix isn't supplied
-
if there are examples of this we need to review what to do. things to consider:
- are the prefixes supplied correct? are we actually seeing errors where an incorrect prefix is being used in our data?
- does this alter the reference as well so do we need to change/add lookups where the wrong prefix is being used
Environment
e.g. OS, Browser, device, app version, network
Steps to reproduce bug
Assign entities for endpoint that contain reference value with :(colon)
Expected behaviour (Include screenshots if applicable)
Assigned lookup should look like:
developer-agreement,,,,local-authority:EXE,DA:20/21=S106:001:20/0284/FUL,4609968,,,
Actual Behaviour(include screenshots if applicable)
DA,,,,local-authority:EXE,20/21=S106:001:20/0284/FUL,4609968,,,
Frequency (how often/how many users/when)
How often?
How many users?
When does it occur?
Impact/ Priority
Estimated time and complexity, including resource dependencies on other teams
Summary Description
When adding an endpoint or assigning entities to an endpoint, if the reference has a :(colon) in the reference then the it is process as prefix:reference
For e.g. if the reference value is
DA:20/21=S106:001:20/0284/FULthen the assign-entities process considers it has prefix:referenceImplement a fix such that the entire value is considered as a reference and the value isn't split.
Technical Approach
The entity reference phase for some reason attempts to split the curie from the reference column. This wouldn't be a problem if the reference wasn't able to contain ':' itself. because it is able to contain ':' we are seeing that some references are being split when they shouldn't
Are there are examples in our code base where this is being used? might need to add some logging to check as we might not know what we're breaking if we turn it off. Check a random set of collections including:
once we have checked a sample of collections and if we see no examples of where this is used we should look at adjusting the phase (not just putting a hot fix on it) we should only attempt to use the reference prefix if sef.prefix isn't supplied
if there are examples of this we need to review what to do. things to consider:
Environment
e.g. OS, Browser, device, app version, network
Steps to reproduce bug
Assign entities for endpoint that contain reference value with :(colon)
Expected behaviour (Include screenshots if applicable)
Assigned lookup should look like:
developer-agreement,,,,local-authority:EXE,DA:20/21=S106:001:20/0284/FUL,4609968,,,Actual Behaviour(include screenshots if applicable)
DA,,,,local-authority:EXE,20/21=S106:001:20/0284/FUL,4609968,,,Frequency (how often/how many users/when)
How often?
How many users?
When does it occur?
Impact/ Priority
Estimated time and complexity, including resource dependencies on other teams