From ac11892b928301989cdd7b918ec48f2f9e9c5ff6 Mon Sep 17 00:00:00 2001 From: Jason Zhu Date: Thu, 12 Feb 2026 19:31:30 +0000 Subject: [PATCH] Trivial cleanup after neuron_minimum_dissolve_delay_to_vote_seconds was initialized --- ...upgrade_canisters_with_golden_nns_state.rs | 27 +++---------------- 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/rs/nns/integration_tests/src/upgrade_canisters_with_golden_nns_state.rs b/rs/nns/integration_tests/src/upgrade_canisters_with_golden_nns_state.rs index 01cee0ad474d..906bf4454933 100644 --- a/rs/nns/integration_tests/src/upgrade_canisters_with_golden_nns_state.rs +++ b/rs/nns/integration_tests/src/upgrade_canisters_with_golden_nns_state.rs @@ -14,15 +14,13 @@ use ic_nns_governance_api::{ MonthlyNodeProviderRewards, NetworkEconomics, Vote, VotingPowerEconomics, }; use ic_nns_test_utils::state_test_helpers::{ - nns_get_most_recent_monthly_node_provider_rewards, nns_wait_for_proposal_execution, - scrape_metrics, + nns_get_most_recent_monthly_node_provider_rewards, scrape_metrics, }; use ic_nns_test_utils::{ common::modify_wasm_bytes, state_test_helpers::{ - get_canister_status, manage_network_economics, nns_cast_vote, - nns_create_super_powerful_neuron, nns_propose_upgrade_nns_canister, - wait_for_canister_upgrade_to_succeed, + get_canister_status, nns_cast_vote, nns_create_super_powerful_neuron, + nns_propose_upgrade_nns_canister, wait_for_canister_upgrade_to_succeed, }, }; use ic_nns_test_utils_golden_nns_state::new_state_machine_with_golden_nns_state_or_panic; @@ -343,25 +341,6 @@ fn test_upgrade_canisters_with_golden_nns_state() { repetition_number += 1; }; - // TODO[NNS1-3790]: Remove this once the mainnet NNS has initialized the - // TODO[NNS1-3790]: `neuron_minimum_dissolve_delay_to_vote_seconds` field. - let proposal_id = manage_network_economics( - &state_machine, - NetworkEconomics { - voting_power_economics: Some(VotingPowerEconomics { - neuron_minimum_dissolve_delay_to_vote_seconds: Some( - VotingPowerEconomics::DEFAULT_NEURON_MINIMUM_DISSOLVE_DELAY_TO_VOTE_SECONDS, - ), - ..Default::default() - }), - ..Default::default() - }, - neuron_controller, - neuron_id, - ); - vote_yes_with_well_known_public_neurons(&state_machine, proposal_id.id); - nns_wait_for_proposal_execution(&state_machine, proposal_id.id); - let metrics_before = sanity_check::fetch_metrics(&state_machine); perform_sequence_of_upgrades(&nns_canister_upgrade_sequence);