Skip to content

Several questions about code base actuality #26

@qfox

Description

@qfox
  1. hasIntrospection looks like useless check at the moment: https://github.com/dfilatov/inherit/blob/master/lib/inherit.js#L10
  2. Why not to use shims for Object.create, Object.keys, Object.assign (extend), etc.
  3. Can we remove or replace comment with obscene lexic? https://github.com/dfilatov/inherit/blob/master/lib/inherit.js#L43
  4. https://github.com/dfilatov/inherit/blob/master/lib/inherit.js#L49 — it is the same as Object.keys, right?
  5. Why not to use noOp as emptyBase? They are both empty functions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions