Review comments

Author: spoorcc

dfetch/commands/update_patch.py

@@ -129,7 +129,7 @@ def __call__(self, args: argparse.Namespace) -> None:
                     patch_text = superproject.diff(
                         subproject.local_path,
                         revisions=RevisionRange("", ""),
-                        ignore=[Metadata.FILENAME],
+                        ignore=(Metadata.FILENAME,),
                         reverse=True,
                     )
 

dfetch/project/gitsuperproject.py

@@ -119,8 +119,8 @@ def diff(
     ) -> str:
         """Get the diff of two revisions in the given path."""
         local_repo = GitLocalRepo(path)
-        diff_since_revision = str(
-            local_repo.create_diff(revisions.old, revisions.new, ignore, reverse)
+        diff_since_revision = local_repo.create_diff(
+            revisions.old, revisions.new, ignore, reverse
         )
 
         if revisions.new:

dfetch/project/superproject.py

@@ -24,7 +24,7 @@
 logger = get_logger(__name__)
 
 
-@dataclass
+@dataclass(frozen=True)
 class RevisionRange:
     """A revision pair."""
 
@@ -78,13 +78,11 @@ def get_username(self) -> str:
 
     def _get_username_fallback(self) -> str:
         """Get the username of the superproject VCS."""
-        username = ""
+        try:
+            username = getpass.getuser()
+        except (ImportError, KeyError, OSError):
+            username = ""
 
-        if not username:
-            try:
-                username = getpass.getuser()
-            except (ImportError, KeyError, OSError):
-                username = ""
         if not username:
             try:
                 username = os.getlogin()
@@ -165,7 +163,7 @@ def get_file_revision(self, path: str | pathlib.Path) -> str:
     def import_projects() -> Sequence[ProjectEntry]:
         """Import projects from underlying superproject."""
         raise RuntimeError(
-            "Only git or SVN projects can be imported."
+            "Only git or SVN projects can be imported. "
             "Run this command within either a git or SVN repository",
         )