Make all paths absolute and resolve them

fixes #946

Author: ben-edna

dfetch/project/superproject.py

@@ -19,6 +19,7 @@
 from dfetch.project.git import GitSubProject
 from dfetch.project.subproject import SubProject
 from dfetch.project.svn import SvnSubProject
+from dfetch.util.util import resolve_absolute_path
 from dfetch.vcs.git import GitLocalRepo
 from dfetch.vcs.svn import SvnRepo
 
@@ -40,7 +41,9 @@ def __init__(self) -> None:
 
         logger.debug(f"Using manifest {manifest_path}")
         self._manifest = parse(manifest_path)
-        self._root_directory = os.path.dirname(self._manifest.path)
+        self._root_directory = str(
+            resolve_absolute_path(os.path.dirname(self._manifest.path))
+        )
 
     @property
     def root_directory(self) -> str:
@@ -63,11 +66,13 @@ def get_sub_project(self, project: ProjectEntry) -> SubProject | None:
 
     def ignored_files(self, path: str) -> Sequence[str]:
         """Return a list of files that can be ignored in a given path."""
-        if (
-            os.path.commonprefix((pathlib.Path(path).resolve(), self.root_directory))
-            != self.root_directory
-        ):
-            raise RuntimeError(f"{path} not in superproject {self.root_directory}!")
+        resolved_path = resolve_absolute_path(path)
+        root_path = pathlib.Path(self.root_directory)
+
+        if not resolved_path.is_relative_to(root_path):
+            raise RuntimeError(
+                f"{resolved_path} not in superproject {self.root_directory}! "
+            )
 
         if GitLocalRepo(self.root_directory).is_git():
             return GitLocalRepo.ignored_files(path)

dfetch/util/util.py

@@ -159,3 +159,14 @@ def str_if_possible(data: list[str]) -> Union[str, list[str]]:
         if the list is empty, otherwise the original list.
     """
     return "" if not data else data[0] if len(data) == 1 else data
+
+
+def resolve_absolute_path(path: Union[str, Path]) -> Path:
+    """
+    Return a guaranteed absolute Path, resolving symlinks.
+
+    Notes:
+        - Uses os.path.realpath for reliable absolute paths across platforms.
+        - Handles Windows drive-relative paths and expands '~'.
+    """
+    return Path(os.path.realpath(Path(path).expanduser()))